Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set moment locale according to chosen language #5414

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 29, 2020

Fixes #5412

@vercel
Copy link

vercel bot commented Oct 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/kl42wb2sb
✅ Preview: https://open-event-frontend-git-l10n-date.eventyay.now.sh

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #5414 into development will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5414      +/-   ##
===============================================
+ Coverage        23.28%   23.32%   +0.04%     
===============================================
  Files              491      491              
  Lines             5132     5136       +4     
  Branches            37       37              
===============================================
+ Hits              1195     1198       +3     
- Misses            3932     3933       +1     
  Partials             5        5              
Impacted Files Coverage Δ
app/services/l10n.js 65.00% <50.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a0cc8...a91a44a. Read the comment docs.

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/utils/loader.ts  4
         

See the complete overview on Codacy

@iamareebjamal iamareebjamal merged commit 4d5dd30 into fossasia:development Oct 29, 2020
@iamareebjamal iamareebjamal deleted the l10n-date branch October 29, 2020 02:40
sansyrox pushed a commit to sansyrox/open-event-frontend that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dates not translated
2 participants