Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow users to set password while registering for order #5431

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 30, 2020

Fixes #5410

@auto-label auto-label bot added the feature label Oct 30, 2020
@vercel
Copy link

vercel bot commented Oct 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6isqbdel9
✅ Preview: https://open-event-frontend-git-password-register.eventyay.now.sh

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 1 alert when merging 84c0415 into aecfed4 - view on LGTM.com

fixed alerts:

  • 1 for Insecure randomness

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #5431 into development will decrease coverage by 0.07%.
The diff coverage is 9.09%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5431      +/-   ##
===============================================
- Coverage        23.32%   23.24%   -0.08%     
===============================================
  Files              493      493              
  Lines             5158     5167       +9     
  Branches            38       38              
===============================================
- Hits              1203     1201       -2     
- Misses            3950     3961      +11     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/public/index.js 6.34% <ø> (ø)
app/components/forms/orders/guest-order-form.js 14.28% <9.09%> (-5.72%) ⬇️
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30cefe2...84c0415. Read the comment docs.

@iamareebjamal
Copy link
Member Author

@mariobehling Please check if the flow is as expected. Working on emails now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign up process tells user "reset your password" and "forgot your password"
1 participant