Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reorder and rename event dashboard boxes #5471

Merged
merged 4 commits into from
Nov 3, 2020

Conversation

Soumi150
Copy link
Contributor

@Soumi150 Soumi150 commented Nov 3, 2020

Fixes #5468

Short description of what this resolves:

Reorder and rename event dashboard boxes.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Before
Screenshot from 2020-11-03 11-58-40

After making changes
Screenshot (19)

Screenshot (22)_LI

@vercel
Copy link

vercel bot commented Nov 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/c61p4t344
✅ Preview: https://open-event-frontend-git-change1.eventyay.vercel.app

@iamareebjamal
Copy link
Member

Before and after screenshots

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #5471 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5471   +/-   ##
============================================
  Coverage        23.24%   23.24%           
============================================
  Files              493      493           
  Lines             5170     5170           
  Branches            38       38           
============================================
  Hits              1202     1202           
  Misses            3963     3963           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025080d...71ed082. Read the comment docs.

@iamareebjamal
Copy link
Member

And please resolve the conflicts

@Raunaksingh100
Copy link
Member

Raunaksingh100 commented Nov 3, 2020

@Soumi150 if someone do comment i am working on this so first ask that he is not working on it so can i work on it

(It lead to duplicate work)

plz follow the codeheat rules and community rules

cheat

@iamareebjamal
Copy link
Member

If @carrycooldude has a PR, we'll close this one. But we value actual contribution. Not just commenting "I want to work on this" and then disappearing on a trip to Bahamas. We will not stop other contributors from contributing just because someone commented "I want to work on this" or "I am working on this"

If they have commented and started the work, they can send a PR, even an incomplete one as a proof and ask this PR to be closed. We'll do it without any problem. But it's in fashion these days to just say I want to work on this issue and then forget about it. Actual contributions are hurt because of this and this is bad for both the contributors who could fix the issue and get codeheat rewards and also for us because the issue doesn't get solved.

For example, you can't just reserve a Phone from amazon and say "I'll pay for it" and prevent others from buying it. If you don't finalize payment within 2-3 hours, it'll be sold to someone else. We usually allow up to 7 days. But if someone else can immediately start working on something within hours and you haven't started working on it, the issue should go to that person.

That's why please only comment on an issue you actually will be fixing and soon, otherwise anyone else who can send a PR soon will get that. And it is only fair

@iamareebjamal iamareebjamal changed the title Reorder and rename event dashboard boxes fix: Reorder and rename event dashboard boxes Nov 3, 2020
@auto-label auto-label bot added the fix label Nov 3, 2020
@iamareebjamal iamareebjamal merged commit 6f0dcc5 into fossasia:development Nov 3, 2020
@Soumi150 Soumi150 deleted the change1 branch November 3, 2020 19:56
akash2408 pushed a commit to akash2408/open-event-frontend that referenced this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder event dashboard boxes and rename them
3 participants