Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed unneccesary line breaks in event title #5480

Merged
merged 2 commits into from
Nov 4, 2020
Merged

fix: Removed unneccesary line breaks in event title #5480

merged 2 commits into from
Nov 4, 2020

Conversation

Gautam-Arora24
Copy link
Member

Fixes #5474

Changes proposed in this pull request

  1. Remove unnecessary line breaks.

Before
github

After
Screenshot 2020-11-04 at 2 19 48 AM

@vercel
Copy link

vercel bot commented Nov 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/gk5ag6g7l
✅ Preview: https://open-event-frontend-git-development.eventyay.vercel.app

@iamareebjamal iamareebjamal changed the title Removed unneccesary line breaks fix: Removed unneccesary line breaks in event title Nov 4, 2020
@auto-label auto-label bot added the fix label Nov 4, 2020
@iamareebjamal
Copy link
Member

Use flexbox instead because this will look bad on smaller screens

@Gautam-Arora24
Copy link
Member Author

I have checked in smaller screens. It works fine. I can make some changes to this commit only so that it looks good in all screen sizes

@iamareebjamal
Copy link
Member

That is what I am asking

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #5480 into development will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5480      +/-   ##
===============================================
+ Coverage        23.24%   23.30%   +0.05%     
===============================================
  Files              493      493              
  Lines             5170     5170              
  Branches            38       38              
===============================================
+ Hits              1202     1205       +3     
+ Misses            3963     3960       -3     
  Partials             5        5              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0dcc5...3531b0f. Read the comment docs.

@Gautam-Arora24
Copy link
Member Author

Fossasia Trim.mov.zip

The latter commit makes the UI to look good in all screen sizes. I have included a Zip file which demonstrates the video. Kindly have a look

@iamareebjamal iamareebjamal merged commit b2017b3 into fossasia:development Nov 4, 2020
akash2408 pushed a commit to akash2408/open-event-frontend that referenced this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Dashboard: Unwanted Line Break in longer Event Titles
2 participants