Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Public page destortion on different resolution #5501

Merged
merged 7 commits into from
Nov 18, 2020
Merged

fix: Public page destortion on different resolution #5501

merged 7 commits into from
Nov 18, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Nov 6, 2020

Fixes #4001

  • Desired image ratio is 1:1.
  • Compared the same page in different resolutions.
  • fixed displaced text

scrnli_11_6_2020_10-12-56 AM
scrnli_11_6_2020_11-01-55 AM

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2e568ekv0
✅ Preview: https://open-event-frontend-git-publicpage-destortion.eventyay.vercel.app

@mariobehling
Copy link
Member

mariobehling commented Nov 6, 2020

Problem is not solved. Instead

  • images appear smaller on some screen resolutions
  • there is now a bigger white space between images
  • in small resolutions the image is not 1:1 and there is no space between images

Screenshot from 2020-11-06 20-39-53

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #5501 (4fa4b87) into development (5bbb10c) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5501      +/-   ##
===============================================
- Coverage        23.25%   23.07%   -0.19%     
===============================================
  Files              493      494       +1     
  Lines             5182     5210      +28     
  Branches            38       38              
===============================================
- Hits              1205     1202       -3     
- Misses            3972     4003      +31     
  Partials             5        5              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/controllers/register.js 34.28% <0.00%> (ø)
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/routes/public/cfs/index.js 0.00% <0.00%> (ø)
app/controllers/events/view/index.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions.js 0.00% <0.00%> (ø)
app/controllers/events/view/settings.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers.js 0.00% <0.00%> (ø)
app/controllers/events/view/scheduler.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/edit.js 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bbb10c...4fa4b87. Read the comment docs.

overflow: hidden;
width: 250px;
width: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a new class instead of modifying previous one

height: auto;
overflow: hidden;
width: 100%;
}

.thumbnail-square img {
.featured-speaker img {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing the class, it will break every other place this class it used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that thumbnail class is also present their. I have added new class for featured -speaker only on public page in speaker-item.

.thumbnail-square {
  height: 300px;
  overflow: hidden;
}

.thumbnail-square img {
  min-height: 100%;
  object-fit: cover;
}

.featured-speaker {
  height: auto;
  overflow: hidden;
  width: 100%;
}

.featured-speaker img {
  min-height: 100%;
  min-width: 100%;
  object-fit: cover;
}

@maze-runnar
Copy link
Contributor Author

@iamareebjamal please review this PR.

@maze-runnar
Copy link
Contributor Author

@mariobehling I have made changes as per requirement.

@iamareebjamal iamareebjamal merged commit b11184d into fossasia:development Nov 18, 2020
@maze-runnar maze-runnar deleted the publicpage-destortion branch November 18, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page design of event page distorted depending on screen resolution
3 participants