-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Public page destortion on different resolution #5501
fix: Public page destortion on different resolution #5501
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2e568ekv0 |
Codecov Report
@@ Coverage Diff @@
## development #5501 +/- ##
===============================================
- Coverage 23.25% 23.07% -0.19%
===============================================
Files 493 494 +1
Lines 5182 5210 +28
Branches 38 38
===============================================
- Hits 1205 1202 -3
- Misses 3972 4003 +31
Partials 5 5
Continue to review full report at Codecov.
|
overflow: hidden; | ||
width: 250px; | ||
width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a new class instead of modifying previous one
height: auto; | ||
overflow: hidden; | ||
width: 100%; | ||
} | ||
|
||
.thumbnail-square img { | ||
.featured-speaker img { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you changing the class, it will break every other place this class it used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that thumbnail class is also present their. I have added new class for featured -speaker only on public page in speaker-item.
.thumbnail-square {
height: 300px;
overflow: hidden;
}
.thumbnail-square img {
min-height: 100%;
object-fit: cover;
}
.featured-speaker {
height: auto;
overflow: hidden;
width: 100%;
}
.featured-speaker img {
min-height: 100%;
min-width: 100%;
object-fit: cover;
}
@iamareebjamal please review this PR. |
@mariobehling I have made changes as per requirement. |
Fixes #4001
Checklist
development
branch.