fix: Handle side menu navigation correctly

[divyamtayal]

Fixes #5123

Short description of what this resolves:

Require two clicks for moving to same section eg. sponsors, tickets etc.

Changes proposed in this pull request:

• Since the problem what I found is that eventListeners were no longer there for each button until an unless we click on any button.
• EventListeners need to be with each button before, so I have resolved this by adding life cycle Hook
• Now it requires only one click as normal to move to diff sections of the page.
• Going to sponsors, getting here etc from speaker, call for speaker etc pages were not exactly taking to the section of page so fixed this.
• Also clicking sponsors, organizers etc from diff page gets to public.index page but the info button remain active so fixed this.

TODO

• Single click and go to section on same page
• Target to specific section from diff page.

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/8polg26o6
✅ Preview: https://open-event-frontend-git-double-click-5123.eventyay.vercel.app

[divyamtayal]

@iamareebjamal Please see to the changes I have made in it and let me know anything to do.

[iamareebjamal]

Go to https://open-event-frontend-i18x7pe1p.vercel.app/e/1f720482/speakers
Click on sponsors
Not working

[lgtm-com]

This pull request introduces 1 alert when merging cb22baf into 79e0cbd - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[divyamtayal]

https://open-event-frontend-i18x7pe1p.vercel.app/e/1f720482/speakers

@iamareebjamal Now I have to work on when going from different page to diff page section.
but being on same page its working?

[iamareebjamal]

Yes

[iamareebjamal]

Yes

[divyamtayal]

@iamareebjamal made the changes. Now getting to section from diff page is working properly.

[lgtm-com]

This pull request introduces 1 alert when merging 3fa86e5 into 79e0cbd - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[divyamtayal]

@iamareebjamal I mean i got the way how it will be working and its working what was said but the problem that will be arising here is that I have used setTimeout funtion for 2 sec but this won't work always bcz what if page took more than 2 sec so I want to know is there a way so that function gets executed only when the page is completely loaded?
or todo something after the transition is done completely?

[lgtm-com]

This pull request introduces 1 alert when merging 9bc5959 into 79e0cbd - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[divyamtayal]

@iamareebjamal https://open-event-frontend-mq4nd06op.vercel.app/e/1f720482/speakers
and clicking on sponsors is working and even other buttons are working

[iamareebjamal]

Fix the build and indentation. Cannot review till then

[lgtm-com]

This pull request introduces 1 alert when merging a35c4a5 into 4fa8591 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[divyamtayal]

@iamareebjamal I have Improved the code for TODO-1 and it looks more cleaner then before.
looking for better solution for TODO-2.
Did u get any of it other then setTimeout?

[divyamtayal]

@iamareebjamal I was reading about ember run loops which I think might help in this case

[iamareebjamal]

They help when you want to run some code in next event loop iteration

[divyamtayal]

@iamareebjamal Is there a way in which I could run a code after the DOM is completely rendered?
didElementInsert only happens first time, I want everytime.

[iamareebjamal]

What's the usecase? MutationObserver may help but there might be better solution for your specific usecase

[iamareebjamal]

After latest changes, I can't go from other page to info link. Go to speakers and then click on sponsors. Not working

[divyamtayal]

What's the usecase? MutationObserver may help but there might be better solution for your specific usecase

I was thinking of the way in which we can get previous visted route and if the route is speaker or coc etc. we can do dom manipulation like here scrolling.
Now the problem is I can get previous route but need to do DOM after render is complete.

[divyamtayal]

After latest changes, I can't go from other page to info link. Go to speakers and then click on sponsors. Not working

Its working for me

[iamareebjamal]

Easier thing would be to abandon LinkTo or href-to helper and just use pure anchor tags and see if things work

[divyamtayal]

Easier think would be to abandon LinkTo or href-to helper and just use pure anchor tags and see if things work

no it does not work

[divyamtayal]

@iamareebjamal after lot of things doing and researching for this solution, I found a workaround which will be working very good for TODO-2

[divyamtayal]

@iamareebjamal I have implemented this method for going to section from diff page.
Pls let me know to do any changes.

[iamareebjamal]

It's not going to the section from different page

https://open-event-frontend-git-double-click-5123.eventyay.vercel.app/e/3dbaaa50/coc

Now click on sponsors or organizer

[iamareebjamal]

There's no need for goTo action. This could be simplified even more and thus I have done that. Please check if everything is working as expected

[divyamtayal]

There's no need for goTo action. This could be simplified even more and thus I have done that. Please check if everything is working as expected

Yep everything is working fine. Thanks for improving it.

[iamareebjamal]

Great. Please check gitter