Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Brackets and commas spacing #5508

Merged
merged 3 commits into from
Nov 6, 2020

Conversation

Saumyachitransh01
Copy link
Member

Fixes #5452

Short description of what this resolves:

Spaces added before brackets and removed before commas.

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/inerwz5op
✅ Preview: https://open-event-frontend-git-newbranch.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #5508 (eabe991) into development (190a3d6) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5508      +/-   ##
===============================================
- Coverage        23.25%   23.07%   -0.18%     
===============================================
  Files              493      493              
  Lines             5182     5209      +27     
  Branches            38       38              
===============================================
- Hits              1205     1202       -3     
- Misses            3972     4002      +30     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/controllers/events/view/index.js 0.00% <0.00%> (ø)
app/controllers/events/view/scheduler.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/create.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/edit.js 0.00% <0.00%> (ø)
app/controllers/events/view/settings.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers/create.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers/edit.js 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e0cbd...53ab1ca. Read the comment docs.

@iamareebjamal iamareebjamal changed the title Spaces and commas fixed fix: Brackets and commas spacing Nov 6, 2020
@auto-label auto-label bot added the fix label Nov 6, 2020
@iamareebjamal iamareebjamal merged commit a242673 into fossasia:development Nov 6, 2020
@Saumyachitransh01 Saumyachitransh01 deleted the newBranch branch November 7, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue with brackets and commas across platform
2 participants