Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display sponsor size according to their level #5532

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Nov 9, 2020

Fixes #5455

image
image

@vercel
Copy link

vercel bot commented Nov 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7f7t6zfpn
✅ Preview: https://open-event-frontend-git-sponsor-size.eventyay.vercel.app

@lgtm-com
Copy link

lgtm-com bot commented Nov 9, 2020

This pull request introduces 1 alert when merging 3f2edb3 into e3aba98 - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #5532 (3f2edb3) into development (84027ee) will increase coverage by 0.27%.
The diff coverage is 88.88%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5532      +/-   ##
===============================================
+ Coverage        23.07%   23.34%   +0.27%     
===============================================
  Files              494      494              
  Lines             5210     5226      +16     
  Branches            38       38              
===============================================
+ Hits              1202     1220      +18     
+ Misses            4003     4001       -2     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/register.js 34.28% <0.00%> (ø)
app/components/public/sponsor-list.js 94.73% <94.11%> (-5.27%) ⬇️
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84027ee...17e1c8e. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 608f714 into fossasia:development Nov 9, 2020
@iamareebjamal iamareebjamal deleted the sponsor-size branch November 9, 2020 02:56
@mariobehling
Copy link
Member

Yes, I see this, but it is not better than before.

The problem is some logos are too close together. On the hand some logos are too small and the organizer is either too big or too small depending on where in the list they are. We need a different approach, where we can give the organizer more control about the size of the logos in the user interface.

Let me formulate an approach in detail. I am afraid it is not working so easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sponsors: Organizers wants to have bigger logos for main sponsors
2 participants