feat: Added options for Outlook, Yahoo to add to calendar #5541
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3e1vax1q4 |
Codecov Report
@@ Coverage Diff @@
## development #5541 +/- ##
===============================================
+ Coverage 23.26% 23.71% +0.44%
===============================================
Files 494 498 +4
Lines 5226 5255 +29
Branches 39 44 +5
===============================================
+ Hits 1216 1246 +30
+ Misses 4004 4003 -1
Partials 6 6
Continue to review full report at Codecov.
|
|
Think about this for a moment. If it was working already, why would I have commented it out?
If it was just that, uncommenting some lines, I would have done it in the PR myself and not reopened the issue |
|
@iamareebjamal For local it was working fine, I will surely look into this |
|
@iamareebjamal - as the description of the event goes too long, the add to calendar on outlook crashes. We need to have some limit of the description text when adding the event to outlook. Check this https://open-event-frontend-kpkdr6kyl.vercel.app/e/ae73f280 |
|
Then please add the limit |
| @@ -49,7 +49,7 @@ export default class AddToCalender extends Component<Args> { | |||
| const { event } = this.args; | |||
| const startTime = this.startsAt.utc().format('YYYY[-]MM[-]DDTHH[:]mm[:]SS[Z]'); | |||
| const endTime = this.endsAt.utc().format('YYYY[-]MM[-]DDTHH[:]mm[:]SS[Z]'); | |||
| return `https://outlook.live.com/calendar/0/deeplink/compose?path=/calendar/action/compose&rru=addevent&subject=${event.name}&startdt=${startTime}&enddt=${endTime}&body=${event.description}&location=${this.args.location}`; | |||
| return `https://outlook.live.com/calendar/0/deeplink/compose?subject=${event.name}&startdt=${startTime}&enddt=${endTime}&body=${(event.description).substring(0,80)}&location=${this.args.location}`; | |||
There was a problem hiding this comment.
80 is quite small, is it max?
There was a problem hiding this comment.
It's no where documented, I will have to try and test what is the limit.
There was a problem hiding this comment.
Also event name and description show + instead of space. Check if there is an easy fix, otherwise it is fine
|
@iamareebjamal The outlook is crashing for 1500+ char limits. The url should max contain 2048 characters (GET) request. IMO it was crashing because of this. So therefore I have truncated the string to 1000characters. and the + in title is resolved |
|
How was + issue resolved |
I was creating the event on the browser and check how the URl Address changed with enteries. |
Fixes #5072
Short description of what this resolves:
Add options for add to calendar
Changes proposed in this pull request:
Checklist
developmentbranch.