Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Footer use same width as above tiles in mobile view #5568

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5563

Short description of what this resolves:

With this PR the footer on the mobile view have the same spacing to the left and right as the above area - with the tiles.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screenshots

before

y1

after

z1

@vercel
Copy link

vercel bot commented Nov 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2eysuc14w
✅ Preview: https://open-event-frontend-git-footer-fix.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #5568 (53de792) into development (a0d1679) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5568   +/-   ##
============================================
  Coverage        23.71%   23.71%           
============================================
  Files              498      498           
  Lines             5255     5255           
  Branches            44       44           
============================================
  Hits              1246     1246           
  Misses            4003     4003           
  Partials             6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d1679...53de792. Read the comment docs.

@sachinchauhan2889
Copy link
Contributor Author

@mariobehling @iamareebjamal sir, this PR is ready for review

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see that the Connect with us menu items and footer bottom links are missing. Could you add them as well in this issue, please? Thanks.

@sachinchauhan2889
Copy link
Contributor Author

@mariobehling @iamareebjamal sir, please check deployment. Connect with us menu items and footer bottom links all are present. These are not present in my screenshots because i haven't added socialLinks in my locale setup. It seems everything working fine.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, true. Sorry about that. Thank you!

@iamareebjamal iamareebjamal merged commit 1ee1b65 into fossasia:development Nov 11, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the footer-fix branch November 13, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile View: Footer use same width as above tiles
3 participants