-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Footer use same width as above tiles in mobile view #5568
fix: Footer use same width as above tiles in mobile view #5568
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2eysuc14w |
Codecov Report
@@ Coverage Diff @@
## development #5568 +/- ##
============================================
Coverage 23.71% 23.71%
============================================
Files 498 498
Lines 5255 5255
Branches 44 44
============================================
Hits 1246 1246
Misses 4003 4003
Partials 6 6 Continue to review full report at Codecov.
|
@mariobehling @iamareebjamal sir, this PR is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see that the Connect with us menu items and footer bottom links are missing. Could you add them as well in this issue, please? Thanks.
@mariobehling @iamareebjamal sir, please check deployment. Connect with us menu items and footer bottom links all are present. These are not present in my screenshots because i haven't added socialLinks in my locale setup. It seems everything working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, true. Sorry about that. Thank you!
Fixes #5563
Short description of what this resolves:
With this PR the footer on the mobile view have the same spacing to the left and right as the above area - with the tiles.
Checklist
development
branch.Screenshots
before
after