Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mobile: Substitute Create Event with Login #5569

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Nov 11, 2020

Fixes #5564

Changes proposed in this pull request:

  • Instead of "Create Event" show "Login" if user is not logged in

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

screenshots

before
s3

after
s1
s2

@vercel
Copy link

vercel bot commented Nov 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/rdkn57v6k
✅ Preview: https://open-event-frontend-git-navbar-fix.eventyay.vercel.app

snitin315
snitin315 previously approved these changes Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #5569 (073bb20) into development (a0d1679) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5569   +/-   ##
============================================
  Coverage        23.71%   23.71%           
============================================
  Files              498      498           
  Lines             5255     5255           
  Branches            44       44           
============================================
  Hits              1246     1246           
  Misses            4003     4003           
  Partials             6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d1679...073bb20. Read the comment docs.

@iamareebjamal
Copy link
Member

@mariobehling It is a standard to have hamburger menu on top left. Material Design and most sites like Facebook, Twitter place it on left. Android Apps display it on left as well.

@mariobehling
Copy link
Member

@mariobehling It is a standard to have hamburger menu on top left. Material Design and most sites like Facebook, Twitter place it on left. Android Apps display it on left as well.

Ok, I looked at eventbrite. They have a bit different looking menu with three dots, but they have it on the right in front of "sign in".

@sachinchauhan2889 @iamareebjamal But, in that case please leave the burger on the left and only keep the change about the login.

@sachinchauhan2889
Copy link
Contributor Author

@iamareebjamal @mariobehling sir, Done. please review

@iamareebjamal iamareebjamal changed the title fix: Move Burger Menu and Substitute Create Event with Login fix: Mobile: Substitute Create Event with Login Nov 11, 2020
@iamareebjamal iamareebjamal merged commit e9569f9 into fossasia:development Nov 11, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the navbar-fix branch November 13, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile View Top Menu: Move Burger Menu and Substitute Create Event with Login
4 participants