-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Mobile: Substitute Create Event with Login #5569
fix: Mobile: Substitute Create Event with Login #5569
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/rdkn57v6k |
Codecov Report
@@ Coverage Diff @@
## development #5569 +/- ##
============================================
Coverage 23.71% 23.71%
============================================
Files 498 498
Lines 5255 5255
Branches 44 44
============================================
Hits 1246 1246
Misses 4003 4003
Partials 6 6 Continue to review full report at Codecov.
|
@mariobehling It is a standard to have hamburger menu on top left. Material Design and most sites like Facebook, Twitter place it on left. Android Apps display it on left as well. |
Ok, I looked at eventbrite. They have a bit different looking menu with three dots, but they have it on the right in front of "sign in". @sachinchauhan2889 @iamareebjamal But, in that case please leave the burger on the left and only keep the change about the login. |
@iamareebjamal @mariobehling sir, Done. please review |
Fixes #5564
Changes proposed in this pull request:
Checklist
development
branch.screenshots
before
after