-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: No error shown when image upload fails #5595
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6g6dzvd7p |
Codecov Report
@@ Coverage Diff @@
## development #5595 +/- ##
===============================================
- Coverage 23.69% 23.69% -0.01%
===============================================
Files 498 498
Lines 5258 5259 +1
Branches 44 44
===============================================
Hits 1246 1246
- Misses 4006 4007 +1
Partials 6 6
Continue to review full report at Codecov.
|
this.set('uploadingImage', false); | ||
this.set('errorMessage', this.i18n.t('An unexpected error has occurred.')); | ||
this.set('selectedImage', null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
as after showing the error image is till showing there and it could be
confusing that image is uploaded or not this will remove the image
…On Fri, Nov 13, 2020 at 6:43 AM Areeb Jamal ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/components/widgets/forms/image-upload.js
<#5595 (comment)>
:
> this.set('uploadingImage', false);
- this.set('errorMessage', this.i18n.t('An unexpected error has occurred.'));
+ this.set('selectedImage', null);
Why
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5595 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOTTIAAXR45JEJX7PNOHVITSPSB25ANCNFSM4TTVV7RA>
.
|
Fixes #4222
Short description of what this resolves:
Changes proposed in this pull request:
Checklist
development
branch.