Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No error shown when image upload fails #5595

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

akash2408
Copy link
Contributor

Fixes #4222

Short description of what this resolves:

ezgif com-gif-maker (3)

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6g6dzvd7p
✅ Preview: https://open-event-frontend-git-image.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #5595 (b5f1f01) into development (8719978) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5595      +/-   ##
===============================================
- Coverage        23.69%   23.69%   -0.01%     
===============================================
  Files              498      498              
  Lines             5258     5259       +1     
  Branches            44       44              
===============================================
  Hits              1246     1246              
- Misses            4006     4007       +1     
  Partials             6        6              
Impacted Files Coverage Δ
app/components/widgets/forms/image-upload.js 22.64% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8719978...d02883f. Read the comment docs.

this.set('uploadingImage', false);
this.set('errorMessage', this.i18n.t('An unexpected error has occurred.'));
this.set('selectedImage', null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why

@akash2408
Copy link
Contributor Author

akash2408 commented Nov 13, 2020 via email

@iamareebjamal iamareebjamal changed the title No error shown when image upload fails #4222 fix: No error shown when image upload fails Nov 13, 2020
@auto-label auto-label bot added the fix label Nov 13, 2020
iamareebjamal
iamareebjamal previously approved these changes Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error shown when image upload fails
2 participants