New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove historic countries that do not exist today from country list #5612

Merged

iamareebjamal merged 3 commits into fossasia:development from sachinchauhan2889:country-fix

Nov 18, 2020

Contributor

sachinchauhan2889 commented Nov 13, 2020

Fixes #5604

Short description of what this resolves:

remove all old countries.

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

auto-label bot added the fix label

vercel bot commented Nov 13, 2020 •

edited

Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7zawc5m5h
✅ Preview: https://open-event-frontend-git-country-fix.eventyay.vercel.app

vercel bot deployed to Preview

November 13, 2020 16:20

View deployment

codecov bot commented Nov 13, 2020 •

edited

Loading

Codecov Report

Merging #5612 (ec22808) into development (aa99edd) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #5612   +/-   ##
============================================
  Coverage        23.43%   23.43%           
============================================
  Files              508      508           
  Lines             5377     5377           
  Branches            47       47           
============================================
  Hits              1260     1260           
  Misses            4109     4109           
  Partials             8        8

Impacted Files	Coverage Δ
app/utils/dictionary/demography.ts	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa99edd...ec22808. Read the comment docs.

sachinchauhan2889 changed the title ~~fix: Country List in Forms show historic countries that do not exist today~~ fix: Remove historic countries that do not exist today from country list

mariobehling reviewed

View reviewed changes

app/utils/dictionary/demography.ts Outdated

-                {
-                  name : 'Czech Republic',
-                  code : 'CZ'
-                },
                 {
                   name : 'German Democratic Republic',
                   code : 'DD'

Member

mariobehling Nov 13, 2020

No longer in existence.

mariobehling reviewed

View reviewed changes

app/utils/dictionary/demography.ts Outdated

-                {
-                  name : 'Hong Kong',
-                  code : 'HK'
-                },

Member

mariobehling Nov 13, 2020

Please keep Hong Kong.

mariobehling reviewed

View reviewed changes

app/utils/dictionary/demography.ts Outdated

-                {
-                  name : 'Taiwan',
-                  code : 'TW'
-                },

Member

mariobehling Nov 13, 2020

Taiwan is an existing territory even though China does not recognize it. Where did you get the info for that list? I am not an expert on all countries but it seems not all data is correct here.

mariobehling reviewed

View reviewed changes

app/utils/dictionary/demography.ts

-                {
-                  name : 'East Timor',
-                  code : 'TP'
-                },

Member

mariobehling Nov 13, 2020

Please check. I think it still exists.

mariobehling reviewed

View reviewed changes

app/utils/dictionary/demography.ts Outdated

-                {
-                  name : 'Uganda',
-                  code : 'UG'
-                },

Member

mariobehling Nov 13, 2020

Why no more Uganda?

mariobehling reviewed

View reviewed changes

app/utils/dictionary/demography.ts

-                {
-                  name : 'Uzbekistan',
-                  code : 'UZ'
-                },

Member

mariobehling Nov 13, 2020

still in existence

mariobehling requested changes

View reviewed changes

Member

mariobehling left a comment

These changes do not seem to be entirely correct. Please do more research about this information and also update if a country name or region name has changed. Also point to where you found the information. So we can understand it. Thanks.

Contributor Author

sachinchauhan2889 commented Nov 14, 2020

These changes do not seem to be entirely correct. Please do more research about this information and also update if a country name or region name has changed. Also point to where you found the information. So we can understand it. Thanks.

ok sir, i will check every country one by one

Member

MeghalBisht commented Nov 15, 2020

These changes do not seem to be entirely correct. Please do more research about this information and also update if a country name or region name has changed. Also point to where you found the information. So we can understand it. Thanks.

ok sir, i will check every country one by one

Hey, are you still working on it?

Contributor Author

sachinchauhan2889 commented Nov 16, 2020

Hey, are you still working on it?

yes

MeghalBisht reviewed

View reviewed changes

Member

MeghalBisht left a comment

You can use this resource. It has all the countries recognized by the UN(2020).
https://www.worldometers.info/geography/countries-of-the-world/

Contributor Author

sachinchauhan2889 commented Nov 16, 2020

You can use this resource. It has all the countries recognized by the UN(2020).
https://www.worldometers.info/geography/countries-of-the-world/

@MeghalBisht thanks.

Member

iamareebjamal commented Nov 16, 2020 •

edited

Loading

https://github.com/annexare/Countries/blob/master/dist/countries.json

const countries = await (await fetch('https://raw.githubusercontent.com/annexare/Countries/master/dist/countries.json')).json()
Object.entries(countries).map(([code, { name }]) => ({ code, name }))

sachinchauhan2889 closed this

sachinchauhan2889 reopened this

sachinchauhan2889 added 2 commits

November 18, 2020 16:46


          remove-country

1ca40dc


          sync

6925a62

sachinchauhan2889 force-pushed the country-fix branch from 41da219 to 6925a62 Compare

November 18, 2020 11:16

vercel bot deployed to Preview

November 18, 2020 11:16

View deployment

Contributor Author

sachinchauhan2889 commented Nov 18, 2020

https://github.com/annexare/Countries/blob/master/dist/countries.json

const countries = await (await fetch('https://raw.githubusercontent.com/annexare/Countries/master/dist/countries.json')).json()
Object.entries(countries).map(([code, { name }]) => ({ code, name }))

@iamareebjamal sir, I tried this.
But top level await is not working.
getting error ---> top-level 'await' expressions are only allowed when the 'module' option is set to 'esnext' or 'system', and the 'target' option is set to 'es2017' or higher.
I also used await in async function but error remain there.

Thats why I have totally matched counries in our demography,ts with your provided list. i have checked each and every country one by one and correct them and remove them.

Member

iamareebjamal commented Nov 18, 2020

I meant run it in your browser console and copy it here, but you seemed to have done the same already


          Merge branch 'development' into country-fix

ec22808

vercel bot deployed to Preview

November 18, 2020 12:28

View deployment

Contributor Author

sachinchauhan2889 commented Nov 18, 2020

I meant run it in your browser console and copy it here, but you seemed to have done the same already

@iamareebjamal yes, sir.

iamareebjamal merged commit 1d2518e into fossasia:development

sachinchauhan2889 deleted the country-fix branch

November 18, 2020 13:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix