Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change position of Paypal/Pay Now Button #5621

Merged
merged 1 commit into from
Nov 14, 2020
Merged

fix: Change position of Paypal/Pay Now Button #5621

merged 1 commit into from
Nov 14, 2020

Conversation

MeghalBisht
Copy link
Member

@MeghalBisht MeghalBisht commented Nov 14, 2020

Fixes #5615

Short description of what this resolves:

Moves the Paypal/Pay Now button (on the order page) to the right hand side as requested. (refer image attached) and removes the extra white space.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Attachments -

2020-11-14 (5)

@vercel
Copy link

vercel bot commented Nov 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/36k6neerc
✅ Preview: https://open-event-frontend-git-development.eventyay.vercel.app

@iamareebjamal
Copy link
Member

@MeghalBisht This is copied directly from #5618. I know this because you have even copied the indentation and logical errors from the PR

@MeghalBisht
Copy link
Member Author

@iamareebjamal I have not added any code except the break line (as the spacing was requested in the issue) so indentation is automatically followed. Please elaborate the logical error

@mariobehling
Copy link
Member

@MeghalBisht Maybe make it more transparent if you cooperate on PRs or reuse code. So, we can attribute contributions correctly. Hope to see you getting deeper into the project.

Looks good to me. Thanks.

@iamareebjamal iamareebjamal changed the title Paypal/Pay Now Button's position changed fix: Xhange position of Paypal/Pay Now Button Nov 14, 2020
@auto-label auto-label bot added the fix label Nov 14, 2020
@iamareebjamal iamareebjamal changed the title fix: Xhange position of Paypal/Pay Now Button fix: Change position of Paypal/Pay Now Button Nov 14, 2020
@iamareebjamal iamareebjamal merged commit 5979194 into fossasia:development Nov 14, 2020
@MeghalBisht
Copy link
Member Author

@MeghalBisht Maybe make it more transparent if you cooperate on PRs or reuse code. So, we can attribute contributions correctly. Hope to see you getting deeper into the project.

Looks good to me. Thanks.

This was my first PR here, will keep this in mind from now on. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Checkout Page: Move Paypal and "Pay Now" button below first right hand side box and expand
3 participants