Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Icon updated for "Ticket Buyer Information" #5625

Merged
merged 2 commits into from
Nov 19, 2020
Merged

fix: Icon updated for "Ticket Buyer Information" #5625

merged 2 commits into from
Nov 19, 2020

Conversation

MeghalBisht
Copy link
Member

Fixes #5624

Short description of what this resolves:

Icon changed for the "Ticket Buyer" information.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Attachments -

2020-11-14 (7)

@vercel
Copy link

vercel bot commented Nov 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/k41qe9ecp
✅ Preview: https://open-event-frontend-git-development.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #5625 (6880c1c) into development (1017f3b) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5625      +/-   ##
===============================================
- Coverage        23.73%   23.73%   -0.01%     
===============================================
  Files              498      498              
  Lines             5270     5275       +5     
  Branches            47       47              
===============================================
+ Hits              1251     1252       +1     
- Misses            4011     4015       +4     
  Partials             8        8              
Impacted Files Coverage Δ
app/components/public/ticket-list.js 19.00% <20.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae084a...6880c1c. Read the comment docs.

Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20201114-181302
Add this icon on order form also.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase!

app/templates/orders/pending.hbs Outdated Show resolved Hide resolved
Copy link
Member

@Saumyachitransh01 Saumyachitransh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "money bill alternate outline icon".
It might look better.

@MeghalBisht
Copy link
Member Author

Use "money bill alternate outline icon".
It might look better.

It is being used in #5646

@Raunaksingh100
Copy link
Member

Raunaksingh100 commented Nov 15, 2020

Use "money bill alternate outline icon".
It might look better.

It is being used in #5646

You can also use it doesn't matter
The purpose of your pr and my pr is different

#5646

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@iamareebjamal iamareebjamal changed the title Icon updated for "Ticket Buyer Information" fix: Icon updated for "Ticket Buyer Information" Nov 19, 2020
@iamareebjamal iamareebjamal merged commit 9314043 into fossasia:development Nov 19, 2020
@auto-label auto-label bot added the fix label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Page and Complete Order Page: Choose better icon for "Ticket Buyer Information"
7 participants