Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: up to 12 events should be listed in cfs #5679

Merged
merged 4 commits into from
Nov 18, 2020
Merged

fix: up to 12 events should be listed in cfs #5679

merged 4 commits into from
Nov 18, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #4697
3. Call for Speakers

  • Up to 12 events should be listed here and there should be a "more link" below to show more events on the cfs page if there are more events

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/eqbdo3yos
✅ Preview: https://open-event-frontend-git-frontpage-standard.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #5679 (156fa60) into development (5d34f21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5679   +/-   ##
============================================
  Coverage        23.72%   23.72%           
============================================
  Files              498      498           
  Lines             5277     5277           
  Branches            47       47           
============================================
  Hits              1252     1252           
  Misses            4017     4017           
  Partials             8        8           
Impacted Files Coverage Δ
app/routes/index.js 78.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d34f21...156fa60. Read the comment docs.

@@ -25,7 +25,7 @@
{{#if this.model.callForSpeakersEvents}}
<h2 class="main-heading">{{t 'Call for speakers'}}</h2>
<div class="ui stackable three column grid">
{{#each this.cfsEvent as |event|}}
{{#each this.model.callForSpeakersEvents as |event|}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't need a change now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{#each this.model.callForSpeakersEvents as |event|}} or {{#each this.cfsEvent as |event|}}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted it to previous didn't made any changes in this file.

@iamareebjamal iamareebjamal merged commit eb378d8 into fossasia:development Nov 18, 2020
@maze-runnar maze-runnar deleted the frontpage-standard branch December 13, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front Page: Standardize Logic and Admin Control to list events (promoted, featured, cfs etc.) on start page
2 participants