-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: up to 12 events should be listed in cfs #5679
fix: up to 12 events should be listed in cfs #5679
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/eqbdo3yos |
Codecov Report
@@ Coverage Diff @@
## development #5679 +/- ##
============================================
Coverage 23.72% 23.72%
============================================
Files 498 498
Lines 5277 5277
Branches 47 47
============================================
Hits 1252 1252
Misses 4017 4017
Partials 8 8
Continue to review full report at Codecov.
|
app/templates/index.hbs
Outdated
@@ -25,7 +25,7 @@ | |||
{{#if this.model.callForSpeakersEvents}} | |||
<h2 class="main-heading">{{t 'Call for speakers'}}</h2> | |||
<div class="ui stackable three column grid"> | |||
{{#each this.cfsEvent as |event|}} | |||
{{#each this.model.callForSpeakersEvents as |event|}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't need a change now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{#each this.model.callForSpeakersEvents as |event|}}
or {{#each this.cfsEvent as |event|}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted it to previous didn't made any changes in this file.
Fixes #4697
3. Call for Speakers
Checklist
development
branch.