-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ticket sales value #5686
fix: ticket sales value #5686
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/4wtxc0x3t |
app/helpers/round-up.js
Outdated
import { ceil } from 'lodash-es'; | ||
|
||
export function roundUp(params) { | ||
return ceil(params[0], 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Math.ceil
We already have ember math helpers, use round helper from that |
using |
It's not displaying decimals now |
round is not also displaying decimals. For that I have to use custom helper. |
No, you can pass |
Codecov Report
@@ Coverage Diff @@
## development #5686 +/- ##
===============================================
- Coverage 23.72% 23.42% -0.30%
===============================================
Files 498 508 +10
Lines 5277 5374 +97
Branches 47 47
===============================================
+ Hits 1252 1259 +7
- Misses 4017 4107 +90
Partials 8 8
Continue to review full report at Codecov.
|
I'm seeing only 1 digit after decimal |
if there are more than two or two digits after decimal then it will show two digits after decimal. Otherwise wise original number |
Fixes #5631
Checklist
development
branch.