Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make pricing page translatable #5700

Merged

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5647

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

screenshots

before
r3
r4

after converting to deutsch

r1
r2

@vercel
Copy link

vercel bot commented Nov 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/51kqho6jm
✅ Preview: https://open-event-frontend-git-pricing-translatable.eventyay.vercel.app

<td><i class="check icon"></i></td>
</tr>
<tr class="center aligned">
<td rowspan="3"> PRICE </td>
<td rowspan="3">{{t 'PRICE'}}</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it normal case (Price) and use CSS to capitalize

<td rowspan="3"></td>
<td rowspan="3">
<LinkTo @route="create" class="ui blue button">
{{t 'Create Event'}}
</LinkTo>
<h3><i class="dollar icon"></i> FREE</h3></td>
<h3><i class="dollar icon"></i>{{t 'FREE'}}</h3></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #5700 (3b3db24) into development (7c4f3e8) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5700      +/-   ##
===============================================
- Coverage        23.71%   23.60%   -0.12%     
===============================================
  Files              510      510              
  Lines             5422     5422              
  Branches            59       59              
===============================================
- Hits              1286     1280       -6     
- Misses            4121     4126       +5     
- Partials            15       16       +1     
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/services/cache.ts 64.15% <0.00%> (-5.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4f3e8...3b3db24. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 5f6cf04 into fossasia:development Nov 22, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the pricing-translatable branch November 23, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pricing Page: Make it translatable
2 participants