Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sort Events according to Dates by Default #5708

Merged
merged 2 commits into from
Nov 21, 2020
Merged

fix: Sort Events according to Dates by Default #5708

merged 2 commits into from
Nov 21, 2020

Conversation

divyamtayal
Copy link
Member

@divyamtayal divyamtayal commented Nov 21, 2020

Fixes #5175

Short description of what this resolves:

Sort Events according to Dates by Default

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/m1x2krywx
✅ Preview: https://open-event-frontend-git-sort-table-5175.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #5708 (2e8e91e) into development (1757efc) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5708      +/-   ##
===============================================
- Coverage        23.62%   23.60%   -0.02%     
===============================================
  Files              510      510              
  Lines             5418     5422       +4     
  Branches            59       59              
===============================================
  Hits              1280     1280              
- Misses            4123     4126       +3     
- Partials            15       16       +1     
Impacted Files Coverage Δ
app/controllers/admin/events/list.js 0.00% <0.00%> (ø)
app/controllers/events/list.js 23.07% <100.00%> (+13.98%) ⬆️
app/services/cache.ts 64.15% <0.00%> (-5.67%) ⬇️
app/mixins/ember-table-route.js 80.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1757efc...2e8e91e. Read the comment docs.

@divyamtayal
Copy link
Member Author

@daretobedifferent18 Please see the changes made

@iamareebjamal iamareebjamal merged commit 7c4f3e8 into fossasia:development Nov 21, 2020
@divyamtayal divyamtayal deleted the sort-table-5175 branch November 21, 2020 15:21
@divyamtayal divyamtayal restored the sort-table-5175 branch November 21, 2020 15:22
@divyamtayal divyamtayal deleted the sort-table-5175 branch November 23, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Dashboard and Event Admin Dashboard: Sort Events according to Dates by Default
2 participants