-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace link-input with link-field and social-link-field #5709
fix: Replace link-input with link-field and social-link-field #5709
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/8xu4kz86p |
Codecov Report
@@ Coverage Diff @@
## development #5709 +/- ##
===============================================
- Coverage 23.69% 23.60% -0.09%
===============================================
Files 510 509 -1
Lines 5415 5375 -40
Branches 59 59
===============================================
- Hits 1283 1269 -14
+ Misses 4116 4090 -26
Partials 16 16
Continue to review full report at Codecov.
|
@iamareebjamal Please let me know that should I remove segmented links where they where never being used also? |
app/templates/components/forms/admin/content/social-links-form.hbs
Outdated
Show resolved
Hide resolved
Yes, remove all segmented links and also the helper code |
@iamareebjamal should I not delete linkinput comp files?? Also its test file?? |
Commented by mistake. Thought its link-field test |
Any other changes to make? |
Will test and merge tomorrow |
@daretobedifferent18 Please check your gitter |
ok |
@maze-runnar Please review and test locally that everything is working as expected |
ok |
@iamareebjamal I have made all the changes asked for. |
Fixes #5570
Short description of what this resolves:
Replace all link-input component calls with link-field and social-link-field and then remove the component and all segmented link shenanigans from the project
TODO
Checklist
development
branch.