Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove order delete functionality #5713

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

codedsun
Copy link
Contributor

Fixes #

Short description of what this resolves:

feat: Removed order delete functionality

Changes proposed in this pull request:

Changes:

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3gsh9wdzg
✅ Preview: https://open-event-frontend-git-deleteorders.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #5713 (8fb468c) into development (bdeb5b7) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5713      +/-   ##
===============================================
- Coverage        23.66%   23.64%   -0.03%     
===============================================
  Files              510      510              
  Lines             5422     5414       -8     
  Branches            59       59              
===============================================
- Hits              1283     1280       -3     
+ Misses            4124     4118       -6     
- Partials            15       16       +1     
Impacted Files Coverage Δ
app/controllers/events/view/tickets/orders/list.js 0.00% <ø> (ø)
app/services/cache.ts 64.15% <0.00%> (-5.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdeb5b7...8fb468c. Read the comment docs.

@codedsun
Copy link
Contributor Author

@iamareebjamal - Review!

@iamareebjamal iamareebjamal changed the title feat: Removed order delete functionality fix: Remove order delete functionality Nov 22, 2020
@auto-label auto-label bot added fix and removed feature labels Nov 22, 2020
@iamareebjamal iamareebjamal merged commit a7dd303 into fossasia:development Nov 22, 2020
@codedsun
Copy link
Contributor Author

wow! 👍 yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants