Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Jitsi Integration #5720

Merged
merged 6 commits into from
Nov 25, 2020
Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Nov 23, 2020

  • Show password
  • and additional info

#5299 #5101

@vercel
Copy link

vercel bot commented Nov 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/1hi0t0l2m
✅ Preview: https://open-event-frontend-git-jitsi.eventyay.vercel.app

@lgtm-com
Copy link

lgtm-com bot commented Nov 23, 2020

This pull request introduces 1 alert when merging cf7390b into 21cc521 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #5720 (19b604f) into development (a25c9a2) will decrease coverage by 0.07%.
The diff coverage is 10.71%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5720      +/-   ##
===============================================
- Coverage        23.57%   23.50%   -0.08%     
===============================================
  Files              510      512       +2     
  Lines             5430     5459      +29     
  Branches            59       62       +3     
===============================================
+ Hits              1280     1283       +3     
- Misses            4134     4160      +26     
  Partials            16       16              
Impacted Files Coverage Δ
app/components/public/session-item.js 20.00% <ø> (-2.23%) ⬇️
app/controllers/events/list.js 23.07% <ø> (ø)
app/routes/public/sessions.js 0.00% <ø> (ø)
app/routes/public/stream/view.ts 0.00% <0.00%> (ø)
app/components/public/stream/video-stream.ts 4.16% <4.16%> (ø)
app/router.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25c9a2...19b604f. Read the comment docs.

@mariobehling
Copy link
Member

Very good. Works for me. We can iterate on this in follow-up issues including:

  • Jitsi room has scroll bars in some resolutions
  • Also need to add a text link "Join Video Channel" into the description above "Additional Info"
  • Change Video Icon to a button "Join Video"

@iamareebjamal iamareebjamal merged commit 0a34a4e into fossasia:development Nov 25, 2020
@iamareebjamal iamareebjamal deleted the jitsi branch November 25, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants