-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add download ticket option for each attendee #5732
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/c7celpfbs |
@@ -14,6 +14,11 @@ | |||
<i class="user icon"></i> | |||
<label>{{t 'Ticket Holder '}}{{t ' -for- '}}{{holder.ticket.name}}</label> | |||
</div> | |||
<button class="ui labeled icon {{if this.device.isMobile 'fluid'}} button" | |||
{{action this.downloadTicketForAttendee holder.event.name holder.order.id holder.id }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maze-runnar - here the holder.event.name when downloading ticket is undefined, but when i print in console, it gives me the value of the event. Please help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maze-runnar - here the holder.event.name when downloading ticket is undefined, but when i print in console, it gives me the value of the event. Please help
@event.name
for event name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also xplain for @event.name
@maze-runnar plz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in order/view.hbs
<Forms::Orders::AttendeeList
@save="save"
@data={{this.model.order}}
@fields={{this.model.form}}
@event={{this.model.event}} />
Codecov Report
@@ Coverage Diff @@
## development #5732 +/- ##
===============================================
- Coverage 23.64% 23.59% -0.05%
===============================================
Files 510 510
Lines 5414 5425 +11
Branches 59 59
===============================================
Hits 1280 1280
- Misses 4118 4129 +11
Partials 16 16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using it holder.event.name
you can use this.event.name
and for holder.order.id
use this.data.id
and also you can define download action in new.js where other download actions are there so that everything is together
@iamareebjamal - review |
Ticket Holder download not working. Server returns 404 hence corrupted PDF |
Fixes #5623
fossasia/open-event-server#7397
Short description of what this resolves:
feat: Add download ticket option for each attendee
Changes proposed in this pull request:
Checklist
development
branch.