Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add download ticket option for each attendee #5732

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

codedsun
Copy link
Contributor

@codedsun codedsun commented Nov 23, 2020

Fixes #5623
fossasia/open-event-server#7397

Short description of what this resolves:

feat: Add download ticket option for each attendee

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/c7celpfbs
✅ Preview: https://open-event-frontend-git-attendees.eventyay.now.sh

@@ -14,6 +14,11 @@
<i class="user icon"></i>
<label>{{t 'Ticket Holder '}}{{t ' -for- '}}{{holder.ticket.name}}</label>
</div>
<button class="ui labeled icon {{if this.device.isMobile 'fluid'}} button"
{{action this.downloadTicketForAttendee holder.event.name holder.order.id holder.id }}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maze-runnar - here the holder.event.name when downloading ticket is undefined, but when i print in console, it gives me the value of the event. Please help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also how do I align to end this button?
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also how do I align to end this button?
image

<button class="ui right floated button">Right Floated</button>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maze-runnar - here the holder.event.name when downloading ticket is undefined, but when i print in console, it gives me the value of the event. Please help

@event.name for event name.

Copy link
Contributor Author

@codedsun codedsun Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also xplain for @event.name @maze-runnar plz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in order/view.hbs

<Forms::Orders::AttendeeList
        @save="save"
        @data={{this.model.order}}
        @fields={{this.model.form}}
        @event={{this.model.event}} />

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #5732 (020edba) into development (a7dd303) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5732      +/-   ##
===============================================
- Coverage        23.64%   23.59%   -0.05%     
===============================================
  Files              510      510              
  Lines             5414     5425      +11     
  Branches            59       59              
===============================================
  Hits              1280     1280              
- Misses            4118     4129      +11     
  Partials            16       16              
Impacted Files Coverage Δ
app/components/forms/orders/attendee-list.js 0.00% <0.00%> (ø)
.../components/forms/wizard/sessions-speakers-step.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b17949...020edba. Read the comment docs.

Copy link
Member

@divyamtayal divyamtayal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of using it holder.event.name you can use this.event.name and for holder.order.id use this.data.id

and also you can define download action in new.js where other download actions are there so that everything is together

@codedsun
Copy link
Contributor Author

@iamareebjamal - review

@iamareebjamal
Copy link
Member

Ticket Holder download not working. Server returns 404 hence corrupted PDF

@iamareebjamal iamareebjamal merged commit 4b8c61d into fossasia:development Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete Order Page: Implement Per Ticket Download
4 participants