Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: time-picker in mobile view in wizard session-step #5737

Merged
merged 1 commit into from
Nov 24, 2020
Merged

fix: time-picker in mobile view in wizard session-step #5737

merged 1 commit into from
Nov 24, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Nov 24, 2020

fixes #5741

Short description of what this resolves:

scrnli_11_24_2020_8-51-21 AM
scrnli_11_24_2020_9-56-56 AM

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ij9ppi3bo
✅ Preview: https://open-event-frontend-git-time-picker.eventyay.now.sh

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #5737 (a51431d) into development (36c936e) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5737      +/-   ##
===============================================
- Coverage        23.69%   23.63%   -0.06%     
===============================================
  Files              510      510              
  Lines             5415     5415              
  Branches            59       59              
===============================================
- Hits              1283     1280       -3     
- Misses            4116     4119       +3     
  Partials            16       16              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c936e...a51431d. Read the comment docs.

@iamareebjamal
Copy link
Member

Which issue is it fixing?

@iamareebjamal iamareebjamal merged commit dc293be into fossasia:development Nov 24, 2020
@maze-runnar maze-runnar deleted the Time-Picker branch December 13, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard step 5: time-picker not showing in mobile view
2 participants