Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reimplement session route to not reload page on filter #5742

Merged
merged 7 commits into from
Nov 25, 2020

Conversation

codepool867
Copy link
Contributor

@codepool867 codepool867 commented Nov 24, 2020

Fixes #4882

Short description of what this resolves:

Implement going to session heading after filtering

Changes proposed in this pull request:

-Add observer to observe session data of model
-Whenever session is changed on filtering, animate body element to go to session heading.
-Session template is modified for adding session heading id.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6jptrwk2n
✅ Preview: https://open-event-frontend-git-issue14.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #5742 (f2dcb62) into development (4006f52) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5742      +/-   ##
===============================================
- Coverage        23.50%   23.41%   -0.10%     
===============================================
  Files              512      512              
  Lines             5459     5480      +21     
  Branches            62       62              
===============================================
  Hits              1283     1283              
- Misses            4160     4181      +21     
  Partials            16       16              
Impacted Files Coverage Δ
app/controllers/public/sessions.js 0.00% <0.00%> (ø)
app/routes/public/sessions.js 0.00% <0.00%> (ø)
app/components/public/stream/video-stream.ts 4.00% <0.00%> (-0.17%) ⬇️
app/controllers/events/view/scheduler.js 0.00% <0.00%> (ø)
.../components/forms/wizard/sessions-speakers-step.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4006f52...f2dcb62. Read the comment docs.

@mariobehling
Copy link
Member

Thank you. Before going next steps, please resolve merge conflicts.

@codepool867
Copy link
Contributor Author

Thank you. Before going next steps, please resolve merge conflicts.

Resolved.

@lgtm-com
Copy link

lgtm-com bot commented Nov 25, 2020

This pull request introduces 1 alert when merging 4765489 into 4006f52 - view on LGTM.com

new alerts:

  • 1 for Syntax error

Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
@iamareebjamal iamareebjamal changed the title Reimplement session route to not reload page on filter fix: Reimplement session route to not reload page on filter Nov 25, 2020
@auto-label auto-label bot added the fix label Nov 25, 2020
@iamareebjamal iamareebjamal merged commit 5d6f968 into fossasia:development Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement sessions route to not reload page on filter
3 participants