-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reimplement session route to not reload page on filter #5742
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6jptrwk2n |
Codecov Report
@@ Coverage Diff @@
## development #5742 +/- ##
===============================================
- Coverage 23.50% 23.41% -0.10%
===============================================
Files 512 512
Lines 5459 5480 +21
Branches 62 62
===============================================
Hits 1283 1283
- Misses 4160 4181 +21
Partials 16 16
Continue to review full report at Codecov.
|
Thank you. Before going next steps, please resolve merge conflicts. |
Resolved. |
This pull request introduces 1 alert when merging 4765489 into 4006f52 - view on LGTM.com new alerts:
|
Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
Fixes #4882
Short description of what this resolves:
Implement going to session heading after filtering
Changes proposed in this pull request:
-Add observer to observe session data of model
-Whenever session is changed on filtering, animate body element to go to session heading.
-Session template is modified for adding session heading id.
Checklist
development
branch.