fix: Paid Donation ticket sale stats #5782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/34j6g05wf |
mariobehling
previously approved these changes
Nov 27, 2020
This reverts commit cefad3f.
|
|
Codecov Report
@@ Coverage Diff @@
## development #5782 +/- ##
============================================
Coverage 23.50% 23.50%
============================================
Files 512 512
Lines 5445 5445
Branches 63 63
============================================
Hits 1280 1280
Misses 4149 4149
Partials 16 16 Continue to review full report at Codecov.
|
| @@ -4,7 +4,7 @@ | |||
| </div> | |||
| <div class="ui {{if this.device.isMobile 'horizontal'}} three statistics"> | |||
| <div class="statistic"><div class="value">{{this.totalOrders}}</div><div class="label">{{t 'Orders'}}</div></div> | |||
| <div class="statistic"><div class="value">{{round this.totalAmount decimals=2}}</div><div class="label">{{t 'Sales'}}{{#if this.totalAmount}}({{currency-symbol this.model.eventDetail.paymentCurrency}}){{/if}}</div></div> | |||
| <div class="statistic"><div class="value">{{if this.totalAmount (round this.totalAmount decimals=2) '0.00'}}</div><div class="label">{{t 'Sales'}}{{#if this.totalAmount}}({{currency-symbol this.model.eventDetail.paymentCurrency}}){{/if}}</div></div> | |||
There was a problem hiding this comment.
Revert please. Another PR is handling this
iamareebjamal
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5781
Short description of what this resolves:
Earlier:-- Paid donation tickets do not show up on the orders overview page. The calculation of tickets sales works correctly. However the donation tickets show 0 in the table.
this PR resolve this.
screenshots
before
after
Checklist
developmentbranch.