Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move session description display to "expanded area" #5791

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5783

Short description of what this resolves:

move the description to the expanded area

screenshots

before
session card 2

after
sesssion card 1

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2zs6ic48w
✅ Preview: https://open-event-frontend-git-change-description-position.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #5791 (ef2dc55) into development (6924ac0) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5791      +/-   ##
===============================================
+ Coverage        23.45%   23.50%   +0.05%     
===============================================
  Files              512      512              
  Lines             5445     5445              
  Branches            63       63              
===============================================
+ Hits              1277     1280       +3     
+ Misses            4152     4149       -3     
  Partials            16       16              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6924ac0...ca5d845. Read the comment docs.

@iamareebjamal
Copy link
Member

Please remove the divider, it does not look good

image

@iamareebjamal iamareebjamal merged commit 8769f2b into fossasia:development Nov 27, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the change-description-position branch November 27, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Schedule: Move session description display to "expanded area"
2 participants