Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change "Apps" to "Website Generator" and other improvements #5792

Merged
merged 6 commits into from
Nov 28, 2020
Merged

fix: Change "Apps" to "Website Generator" and other improvements #5792

merged 6 commits into from
Nov 28, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Nov 27, 2020 •
edited
Loading

Fixes #5786

screenshots

dashboard 2

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 27, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/bya0qfw8q
✅ Preview: https://open-event-frontend-git-dashboard-enhance.eventyay.now.sh

@auto-label auto-label bot added the fix label Nov 27, 2020
@iamareebjamal
Copy link
Member

Fix the build please

@codecov
Copy link

codecov bot commented Nov 27, 2020 •
edited
Loading

Codecov Report

Merging #5792 (9a5f8af) into development (6924ac0) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5792      +/-   ##
===============================================
+ Coverage        23.45%   23.53%   +0.08%     
===============================================
  Files              512      512              
  Lines             5445     5456      +11     
  Branches            63       63              
===============================================
+ Hits              1277     1284       +7     
- Misses            4152     4156       +4     
  Partials            16       16
Impacted Files Coverage Δ
app/helpers/general-date.js 66.66% <0.00%> (-33.34%) ⬇️
app/components/public/session-item.js 18.18% <0.00%> (-1.82%) ⬇️
app/controllers/public/index.js 6.25% <0.00%> (-0.10%) ⬇️
app/routes/create.js 100.00% <0.00%> (ø)
app/components/public/call-for-speakers.js 0.00% <0.00%> (ø)
app/components/public/stream/video-stream.ts 4.00% <0.00%> (ø)
app/controllers/events/view/videoroom/list.js 0.00% <0.00%> (ø)
app/helpers/header-date.js
app/models/video-stream.ts 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6924ac0...9a5f8af. Read the comment docs.

iamareebjamal
iamareebjamal previously approved these changes Nov 27, 2020
View reviewed changes
@mariobehling
Copy link
Member

mariobehling commented Nov 27, 2020 •
edited
Loading

Thanks, could you reduce the spacing of the text and buttons on the top and bottom please to match other similar areas. Also please left-align the "Create Website" button.

@mariobehling
Copy link
Member

Please see example below.

Screenshot from 2020-11-27 20-56-10

@iamareebjamal
Copy link
Member

Please update screenshot

@sachinchauhan2889
Copy link
Contributor Author

generator

@iamareebjamal
Copy link
Member

Text still has a lot of space above it. Compare to the image by Mario

@sachinchauhan2889
Copy link
Contributor Author

generator new

iamareebjamal
iamareebjamal reviewed Nov 27, 2020
View reviewed changes
app/templates/components/events/view/overview/event-apps.hbs Outdated
<a href="{{this.webAppGeneratorUrl}}" target="_blank" class="ui button" rel="noopener noreferrer">{{t 'Generate Web App'}}</a>
</div>
<div class="row pt-0">
{{t 'You would like to have a dedicated event website with all details, sponsors listing, speakers and sessions and the entire schedule? Simply use the website generator. It transfers the data of the event via an API to our website tool and creates a website for you. You can download the entire site as a zip file and upload it to your own web hosting service. No database set up or framework required. This feature is still in Alpha stage, but is already used actively by a number of events. If you press the below button a tab will open where your website is generated.'}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break the sentences into multiple t statements. This way, translators don't have to retranslate the whole paragraph if a single word changes

mariobehling
mariobehling previously approved these changes Nov 27, 2020
View reviewed changes
@iamareebjamal iamareebjamal merged commit c0c4b6b into fossasia:development Nov 28, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the dashboard-enhance branch November 28, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal left review comments

@mariobehling mariobehling mariobehling left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event Dashboard: Change "Apps" to "Website Generator" and other improvements
3 participants
@sachinchauhan2889 @iamareebjamal @mariobehling