Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make video URL more user friendly #5803

Merged
merged 2 commits into from
Nov 28, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Nov 28, 2020

Fixes #5770

@vercel
Copy link

vercel bot commented Nov 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/nh7dtou4c
✅ Preview: https://open-event-frontend-git-video-url.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #5803 (413d368) into development (53ce749) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5803      +/-   ##
===============================================
- Coverage        23.50%   23.47%   -0.03%     
===============================================
  Files              512      512              
  Lines             5445     5456      +11     
  Branches            63       63              
===============================================
+ Hits              1280     1281       +1     
- Misses            4149     4159      +10     
  Partials            16       16              
Impacted Files Coverage Δ
app/components/public/session-item.js 18.18% <ø> (-1.82%) ⬇️
app/components/public/stream/video-stream.ts 4.00% <ø> (ø)
app/controllers/events/view/videoroom/list.js 0.00% <ø> (ø)
app/models/video-stream.ts 0.00% <0.00%> (ø)
app/router.js 100.00% <100.00%> (ø)
app/helpers/general-date.js 66.66% <0.00%> (-33.34%) ⬇️
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/controllers/public/index.js 6.25% <0.00%> (-0.10%) ⬇️
app/routes/create.js 100.00% <0.00%> (ø)
app/components/public/call-for-speakers.js 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ce749...413d368. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 5e2603b into fossasia:development Nov 28, 2020
@iamareebjamal iamareebjamal deleted the video-url branch November 28, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video Room: Create a suitable shareable URL
1 participant