Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show sales amount with currency and remove symbol after text #5805

Merged
merged 3 commits into from
Nov 28, 2020
Merged

fix: Show sales amount with currency and remove symbol after text #5805

merged 3 commits into from
Nov 28, 2020

Conversation

divyamtayal
Copy link
Member

@divyamtayal divyamtayal commented Nov 28, 2020

Fixes #5801

Screenshots

Screenshot from 2020-11-28 10-10-53

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/hqbtwa0op
✅ Preview: https://open-event-frontend-git-show-currency-5801.eventyay.vercel.app

@divyamtayal
Copy link
Member Author

@iamareebjamal Done

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #5805 (48ffce8) into development (2315c39) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5805   +/-   ##
============================================
  Coverage        23.48%   23.48%           
============================================
  Files              511      511           
  Lines             5454     5454           
  Branches            63       63           
============================================
  Hits              1281     1281           
  Misses            4157     4157           
  Partials            16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2315c39...48ffce8. Read the comment docs.

@iamareebjamal iamareebjamal changed the title Organizer Orders Page: Instead of showing currency with Sales($) show it with the number fix: Show sales amount with currency and remove symbol after text Nov 28, 2020
@auto-label auto-label bot added the fix label Nov 28, 2020
@iamareebjamal iamareebjamal merged commit e8e1d7d into fossasia:development Nov 28, 2020
@divyamtayal divyamtayal deleted the show-currency-5801 branch December 10, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer Orders Page: Instead of showing currency with Sales($) show it with the number
3 participants