-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance session item UI #5819
feat: Enhance session item UI #5819
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/aptw8xoue |
@iamareebjamal It's Done. |
Codecov Report
@@ Coverage Diff @@
## development #5819 +/- ##
===============================================
- Coverage 23.46% 23.38% -0.08%
===============================================
Files 513 513
Lines 5477 5481 +4
Branches 63 63
===============================================
- Hits 1285 1282 -3
- Misses 4176 4183 +7
Partials 16 16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
microlocation and date-time information shift to left side after expanding session card. They must remain on right side even on expanding session.
That was actually a bug before which was not working but now its working correctly |
#5774 is not fixed |
@iamareebjamal only left with #5818 but in this issue actually the link is been added in short Abstract and not in Slide url, so it will remain as it is, I think we can't change that. |
@iamareebjamal Done. |
This pull request introduces 2 alerts when merging 160225f into a5104cc - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks
Oh, in the last iteration the date and time now appear twice. Compare https://open-event-frontend-git-session-expanded-5817.eventyay.vercel.app/e/8fa7fd14/schedule |
@iamareebjamal Made Changes |
This pull request introduces 2 alerts when merging b234454 into a5104cc - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging e75fadf into a5104cc - view on LGTM.com new alerts:
|
@iamareebjamal Pls review. This PR is completed |
@mariobehling I am merging this, but session collapsed will look very cluttered when there is both video stream and slides attached to it Also, we need to think if we still need to show the video link if the session has passed? Because there will be no one there then |
Yes, Thank you. Let's talk about this in the weekly meeting. |
Fixes #5817
Fixes #5774
Fixes #5818
Short description of what this resolves:
Changes proposed in this pull request:
ScreenShots
Checklist
development
branch.