Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase height of language dropdown #5821

Merged
merged 2 commits into from
Nov 30, 2020
Merged

fix: increase height of language dropdown #5821

merged 2 commits into from
Nov 30, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5808

Screenshot from 2020-11-29 15-28-17

  • what should be order of language?

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/aef6xg330
✅ Preview: https://open-event-frontend-git-language-dropdown.eventyay.now.sh

@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #5821 (6920c4d) into development (a5104cc) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5821      +/-   ##
===============================================
- Coverage        23.46%   23.40%   -0.06%     
===============================================
  Files              513      513              
  Lines             5477     5477              
  Branches            63       63              
===============================================
- Hits              1285     1282       -3     
- Misses            4176     4179       +3     
  Partials            16       16              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5104cc...6920c4d. Read the comment docs.

@@ -27,6 +27,11 @@ footer {
}
}

.language.menu {
height: 400px !important;
Copy link
Member

@divyamtayal divyamtayal Nov 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead use

min-height : 400px !important;

and remove

height: 400px !important;
max-height : none !important;

@iamareebjamal iamareebjamal changed the title fix: increasing height of language dropdown fix: increase height of language dropdown Nov 30, 2020
@iamareebjamal iamareebjamal merged commit a33523e into fossasia:development Nov 30, 2020
@maze-runnar maze-runnar deleted the language-dropdown branch December 13, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language Dropdown Menu: Sort according to locale and increase height
3 participants