-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Download Tickets -> All Tickets #5856
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/iq0c0y1zr |
Codecov Report
@@ Coverage Diff @@
## development #5856 +/- ##
===============================================
- Coverage 23.46% 23.42% -0.04%
===============================================
Files 512 512
Lines 5460 5469 +9
Branches 63 65 +2
===============================================
Hits 1281 1281
- Misses 4163 4171 +8
- Partials 16 17 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a white space between the all tickets and invoice button now. Please keep the width of the button as it previously was. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of #5860
I first say I am working on this issue so, why are you spaming
Plz read the contributions introduction this is open source .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be friendly to each other and collaborate. As mentioned elsewhere if two people collaborate and contribute code to an issue together it would also count for both in a coding contest like Codeheat for example. |
@Raunaksingh100 The pr you mentioned was opened around 7 hours after this one. So how could this be a duplicate or spam. Also this tone of communication should not be encouraged in open source. As I already said in the issue I did not see your comment when I started working on this. If the mentors feel that this is already fixed then please feel free to close this. |
@mariobehling Does this look good now? I have made the spacing like it was before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks good. Thank you!
Please keep the tone of the conversation positive and friendly. We are all here to learn as well.
app/templates/orders/view.hbs
Outdated
<div class="d-flex space-between"> | ||
<button class="ui labeled icon {{if this.isLoadingTickets 'loading'}} {{if this.device.isMobile 'fluid'}} button" | ||
<div class="ui padded grid"> | ||
<button class="ui labeled icon left floated seven wide column {{if this.isLoadingTickets 'loading'}} {{if this.device.isMobile 'fluid'}} button" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use flexbox with different style. Your solution is not responsive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use flexbox as before
@iamareebjamal Unfortunately, I could not reproduce the responsiveness issues. Could you please share a screenshot for that. Here is how it looked before on mobile devices - Here is how it looks now - Also, I think under the hood, semantic UI grid uses flexbox only. Please share feedback and suggestions. Thanks |
You have done it above youself. See the difference carefully |
@iamareebjamal Restored flexbox , now the space between the buttons not there on mobile if that was the resposivness issue we were talking about. Please have a look. Thanks |
@iamareebjamal Oh, Thanks. Buttons made equal now. Should I squash my commits? |
Thanks for the contribution |
Fixes #5852
Changes proposed in this pull request:
Please share feedback and suggestions.