Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use event end time in cell-event-date #5890

Merged
merged 2 commits into from
Dec 3, 2020
Merged

fix: Use event end time in cell-event-date #5890

merged 2 commits into from
Dec 3, 2020

Conversation

SARTHAK1SINGH
Copy link
Contributor

@SARTHAK1SINGH SARTHAK1SINGH commented Dec 3, 2020

Fixes #5886

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Dec 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/bs8zh965g
✅ Preview: https://open-event-frontend-git-event-endtime-fix.eventyay.vercel.app

@maze-runnar
Copy link
Contributor

maze-runnar commented Dec 3, 2020

issue number is #5886

Fixes #5889

update issue number here

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #5890 (74d87a9) into development (a78dd3c) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5890      +/-   ##
===============================================
- Coverage        23.48%   23.37%   -0.11%     
===============================================
  Files              511      511              
  Lines             5472     5472              
  Branches            65       65              
===============================================
- Hits              1285     1279       -6     
- Misses            4171     4176       +5     
- Partials            16       17       +1     
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/services/cache.ts 61.40% <0.00%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78dd3c...74d87a9. Read the comment docs.

Copy link
Member

@divyamtayal divyamtayal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@iamareebjamal iamareebjamal changed the title Event End time Correction fix: Use event end time in cell-event-date Dec 3, 2020
@iamareebjamal iamareebjamal merged commit 745c428 into fossasia:development Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Dashboard: Date end time of an event is wrong (showing start time)
4 participants