Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-9127: Add the unique ticket code into the downlad CSV file #9185

Merged
merged 1 commit into from Mar 26, 2024
Merged

Fix-9127: Add the unique ticket code into the downlad CSV file #9185

merged 1 commit into from Mar 26, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2024

Fixes #fossasia/open-event-server#9127

Short description of what this resolves:

  • Add the unique ticket code into the downlad CSV file

Changes proposed in this pull request:

  • Add the unique ticket code into the downlad CSV file

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-event-frontend ❌ Failed (Inspect) Mar 26, 2024 10:37am

@ghost ghost marked this pull request as ready for review March 26, 2024 10:38
@ghost ghost requested review from mariobehling, norbusan, marcoag and cweitat March 26, 2024 10:38
@ghost
Copy link
Author

ghost commented Mar 26, 2024

After I tried to figure out the problem, the UI crashed on the 'View attendees' screen.
I see 2 problems:
1/ If the order has 2 or more tickets, the UI will not display the "Order Id" price.
2/ The "View attendees" screen has 2 columns "Ticket number". I checked the source code and found out this problem happened 7 months ago.

After fixing the above two issues, at "View Attendees" I noticed that the "Order" Column is not the "Ticket ID" in the QR and CSV. Do you want to change the value of the "Orders" column?
Table

Copy link
Member

@norbusan norbusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@norbusan norbusan merged commit e6f8b09 into fossasia:development Mar 26, 2024
8 of 9 checks passed
@mariobehling
Copy link
Member

The issue is now that it only works in English, but not in Vietnamese.

Screenshot from 2024-03-26 15-39-09

@ghost
Copy link
Author

ghost commented Mar 27, 2024

Hi @mariobehling

According to the image you provided, your UI is still using the old source code. Try logging in and logging out again to see if you still have the problem. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants