Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SerialHandler.get_long #230

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

bessman
Copy link
Collaborator

@bessman bessman commented Jul 27, 2024

Summary by Sourcery

This pull request adds a new method, SerialHandler.send_long, to the SerialHandler class, enabling the sending of 4-byte data.

  • New Features:
    • Introduced SerialHandler.send_long method for sending 4-byte data.

Copy link

sourcery-ai bot commented Jul 27, 2024

Reviewer's Guide by Sourcery

This pull request adds a new method send_long to the SerialHandler class in the pslab/serial_handler.py file. The method is implemented using the existing _send method with a size parameter of 4, and it is wrapped using update_wrapper for consistency with other send methods.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bessman - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@bessman bessman merged commit 4e53d8f into fossasia:development Jul 27, 2024
6 checks passed
@bessman bessman deleted the feat/get_long branch July 27, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant