Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response dictionary can be accumulated to a Single Output Class #38

Closed
Kaushl2208 opened this issue Oct 12, 2021 · 3 comments
Closed

Response dictionary can be accumulated to a Single Output Class #38

Kaushl2208 opened this issue Oct 12, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@Kaushl2208
Copy link
Member

Currently the output/response is being provided in the form of separate dictionaries. A dedicated class can be written to make it more modular and efficient.

Ref: Dict_perma

@Kaushl2208 Kaushl2208 added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 12, 2021
@GMishx
Copy link
Member

GMishx commented Oct 12, 2021

I would like to rephrase the requirement. We have dedicated classes in nirjas/output but even while calling nirjas as library, it returns a JSON which needs to be parsed back into Python types.
Instead, if the translation of object to JSON can be done only for CLI calls and not for library/function calls, it will be great.

@ha36d ha36d mentioned this issue Oct 23, 2021
@GMishx
Copy link
Member

GMishx commented Oct 26, 2021

@Kaushl2208 , with #47, we now have the result as Python dictionary. Do we still need a dedicated class for it or can we close the issue?

@Kaushl2208
Copy link
Member Author

@GMishx , This #47 seems like good implementation. Let's close the issue!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants