Output class #47
Merged
Output class #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaushl2208
requested changes
Oct 24, 2021
ha36d
force-pushed
the
output-class
branch
4 times, most recently
from
4d0020a to
7bbff03
Compare
Kaushl2208
approved these changes
Oct 24, 2021
There was a problem hiding this comment.
@ha36d , This looks good to me, Can you try and squash the commits as well? We try to keep our history atomic and clean!!
It's done @Kaushl2208. |
GMishx
approved these changes
Oct 26, 2021
|
@ha36d Please expose the new class Other functionality is working fine. |
|
@GMishx it's ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to fix the second part of #38
Adds a separate class for output to fix the second part of #38