fix(regex): Add negative lookbehind for string #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add negative lookbehind to single line comment regex to make sure the
comment symbol is not part of a string ('#' is a string, not a comment).
Add new function `hashNoCurl()` for Ruby's #{} string syntax.
Also, updated `readMultiLineSame()` to check if the comment starts and
ends in the same line and do not pick a line with comment symbol in
string.
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
GMishx
force-pushed
the
fix/comment-in-string
branch
from
a335e4a to
f0f14c0
Compare
|
Test cases are fixed in #33 along with code quality improvements. Should I cherry-pick them or the branches can be merged separately? |
|
Hey @GMishx , You can cherry pick them! It will be easier to test as well! |
|
I wanted to keep the fixes for test cases separate. There are many other changes as well in how test cases work. So I created separate PR #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add negative lookbehind to single line comment regex to make sure the comment symbol is not part of a string ('#' is a string, not a comment).
Add new function
hashNoCurl()for Ruby's#{}string syntax.Also, updated
readMultiLineSame()to check if the comment starts and ends in the same line and do not pick a line with comment symbol in string.Removed the unused
signfromreadSingleLine().Signed-off-by: Gaurav Mishra mishra.gaurav@siemens.com