Added Docker image support #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMishx
requested changes
Oct 14, 2021
|
While working on requested changes, it will be great if you can squash all commits into one. |
aswinmurali-io
force-pushed
the
docker-support
branch
from
9c4eb9f to
9ca718f
Compare
|
Please review the changes @GMishx |
GMishx
reviewed
Oct 15, 2021
Comment on lines
+1
to
+2
| # Copyright (C) 2020 Ayush Bhardwaj (classicayush@gmail.com), | ||
| # Kaushlendra Pratap (kaushlendrapratap.9837@gmail.com) |
There was a problem hiding this comment.
Please change the copyright text and add your name and email.
.github/workflows/docker-image.yml
Outdated
Comment on lines
5
to
7
| branches: [ master , docker-support ] | ||
| pull_request: | ||
| branches: [ master , docker-support ] |
There was a problem hiding this comment.
Since the CI is running, build on docker-support is no longer required. Please remove it for merge.
chore(docker): Implements Dockerfile for building images. chore(docker): Implements dockerignore file chore(docker): Implements docker image CI chore(docker): Enabling docker CI in docker-support branch to test build process chore(docker): Added docker image artifact upload support fix(docker): Added static docker image label for uploading chore(docker): Changed base image to `python:3.8-alpine` chore(docker): Added license header chore(docker): Removed `docker-support` branch chore(docker): Updated authors
aswinmurali-io
force-pushed
the
docker-support
branch
from
9ca718f to
4c6d1bd
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue #40
What have I done?
Used Alphine as the base for the docker image to make it as small as possible.
Closes #40