Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Julia language #52

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

soham4abc
Copy link
Contributor

Fixes #34

Please can anyone help me or guide me to let me know where my tests are failing?

@GMishx @Kaushl2208

@Kaushl2208
Copy link
Member

Fixes #34

Please can anyone help me or guide me to let me know where my tests are failing?

@GMishx @Kaushl2208

You need to change the testfile:

  1. The current test file contains the unicode characters.
  2. Run Nirjas on the same testfile and analyse the output and share it here as well(the output).

@soham4abc
Copy link
Contributor Author

PS C:\Users\SOHAM\Desktop\misc\tempnirjas> nirjas .\test.jl
{
    "metadata": {
        "filename": ".\\test.jl",
        "lang": "Julia",
        "total_lines": 75,
        "total_lines_of_comments": 8,
        "blank_lines": 16,
        "sloc": 51
    },
    "single_line_comment": [
        {
            "line_number": 5,
            "comment": "get the category, don't process some files"
        },
        {
            "line_number": 15,
            "comment": "process the  lines"
        },
        {
            "line_number": 23,
            "comment": "handle subcategories"
        },
        {
            "line_number": 27,
            "comment": "collect repo info"
        },
        {
            "line_number": 56,
            "comment": "-----------------------------------------------------------------"
        },
        {
            "line_number": 61,
            "comment": "loop over all markdown files in the root directory, appending the records to the list"
        },
        {
            "line_number": 67,
            "comment": "save a csv file"
        },
        {
            "line_number": 75,
            "comment": "module"
        }
    ],
    "cont_single_line_comment": [],
    "multi_line_comment": []
}
PS C:\Users\SOHAM\Desktop\misc\tempnirjas>

@soham4abc
Copy link
Contributor Author

This is what I get when I am running the same test file using nirjas. What I need to change? @Kaushl2208

PS C:\Users\SOHAM\Desktop\misc\tempnirjas> nirjas .\test.jl
{
    "metadata": {
        "filename": ".\\test.jl",
        "lang": "Julia",
        "total_lines": 75,
        "total_lines_of_comments": 8,
        "blank_lines": 16,
        "sloc": 51
    },
    "single_line_comment": [
        {
            "line_number": 5,
            "comment": "get the category, don't process some files"
        },
        {
            "line_number": 15,
            "comment": "process the  lines"
        },
        {
            "line_number": 23,
            "comment": "handle subcategories"
        },
        {
            "line_number": 27,
            "comment": "collect repo info"
        },
        {
            "line_number": 56,
            "comment": "-----------------------------------------------------------------"
        },
        {
            "line_number": 61,
            "comment": "loop over all markdown files in the root directory, appending the records to the list"
        },
        {
            "line_number": 67,
            "comment": "save a csv file"
        },
        {
            "line_number": 75,
            "comment": "module"
        }
    ],
    "cont_single_line_comment": [],
    "multi_line_comment": []
}
PS C:\Users\SOHAM\Desktop\misc\tempnirjas>

@soham4abc
Copy link
Contributor Author

All Checks passed @Kaushl2208 PTAL

nirjas/languages/julia.py Outdated Show resolved Hide resolved
testScript.py Outdated Show resolved Hide resolved
@soham4abc
Copy link
Contributor Author

All requested changes done PTAL @Kaushl2208

@soham4abc soham4abc requested a review from Kaushl2208 January 3, 2022 12:07
@soham4abc
Copy link
Contributor Author

Any more changes required @GMishx @Kaushl2208 ??

Copy link
Member

@Kaushl2208 Kaushl2208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, Needs test!

@soham4abc
Copy link
Contributor Author

Changes LGTM, Needs test!

Nice... Let me know if any more changes are required!

@soham4abc
Copy link
Contributor Author

Any changes required? @Kaushl2208

@soham4abc
Copy link
Contributor Author

Any changes required? @Kaushl2208
@Kaushl2208 @GMishx ??

@Kaushl2208
Copy link
Member

Hey @soham4abc , We will let you know once the testing has been completed for the PR.

Thankyou for your patience. :)

@Kaushl2208
Copy link
Member

Kaushl2208 commented Jan 11, 2022

Hey @soham4abc , I have tested it. Thankyou for your contributions.

Can you Squash the commits into one before I merge it?
CC: @GMishx

@soham4abc soham4abc force-pushed the julia branch 2 times, most recently from 7e5af13 to b0450c4 Compare January 12, 2022 04:05
@soham4abc
Copy link
Contributor Author

Hey @soham4abc , I have tested it. Thankyou for your contributions.

Can you Squash the commits into one before I merge it? CC: @GMishx

changes merged to one commit and rebased

Signed-off-by: Soham Banerjee <sohambanerjee4abc@hotmail.com>
@GMishx GMishx merged commit 56bbf63 into fossology:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need Support for Julia Lang
3 participants