Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql): Add sql language support #55

Merged
merged 1 commit into from
Jan 11, 2022
Merged

feat(sql): Add sql language support #55

merged 1 commit into from
Jan 11, 2022

Conversation

its-sushant
Copy link
Contributor

pull request for #37

@its-sushant its-sushant changed the title Sushant added sql feat(sql): Add sql language support Dec 20, 2021
Kaushl2208
Kaushl2208 requested changes Dec 21, 2021
View reviewed changes
Copy link
Member

@Kaushl2208 Kaushl2208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Can you add the test data file as a raw github content link. On which your test will run on.

@Kaushl2208
Copy link
Member

Hey @its-sushant , You have few whitespaces in sql and main file!
Try and remove it

@its-sushant
Copy link
Contributor Author

Hey @its-sushant , You have few whitespaces in sql and main file! Try and remove it

Ok, I will try to remove it..

GMishx
GMishx requested changes Dec 22, 2021
View reviewed changes
source.txt Outdated Show resolved Hide resolved
Kaushl2208
Kaushl2208 approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@Kaushl2208 Kaushl2208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Looks good! Needs test.

@its-sushant
feat(sql): Add sql language support
fe9b44b 
feat(sql): Add sql language support

feat(sql): Add sql language support

feat(sql): Add sql language support

feat(sql): Add sql language support
@Kaushl2208
Copy link
Member

Hey @its-sushant , Thankyou for your contributions. I have tested it

CC: @GMishx

@Kaushl2208 Kaushl2208 merged commit 6602d4e into fossology:master Jan 11, 2022
@GMishx GMishx mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx requested changes

@Kaushl2208 Kaushl2208 Kaushl2208 approved these changes

Assignees
No one assigned
Labels
needs test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@its-sushant @Kaushl2208 @GMishx