Adapt viirs2pps also to viirs_compact #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
- Coverage 77.37% 77.27% -0.11%
==========================================
Files 21 21
Lines 1472 1474 +2
Branches 125 126 +1
==========================================
Hits 1139 1139
- Misses 306 308 +2
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 8204486498Details
💛 - Coveralls |
| @@ -41,6 +41,9 @@ | |||
| help="Output directory where to store the level1c file") | |||
| parser.add_argument('--iband', action='store_true', | |||
| help="Iband resolution include I01-I03, M15-M16 and optional M09, M14") | |||
| parser.add_argument('--reader', type=str, nargs='?', | |||
There was a problem hiding this comment.
Do we really handle nargs (multiple readers) and if, how does it work? Try the first one first?
There was a problem hiding this comment.
The nargs ='?' means that the argument can be present or not https://docs.python.org/3/library/argparse.html.
There was a problem hiding this comment.
You are correct. I have misundertsood it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest level1c4ppsflake8