Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split VGAC files at midnight #87

Merged
merged 9 commits into from
Jul 5, 2024

Conversation

ninahakansson
Copy link
Collaborator

Split VGAC files at midnight and allow for sending in an outpath to be filled with start-time information.

vgac2pps.py -o out_dir/%Y%m%d/ ~/DATA_MISC/CLARAA3p5/VGAC_VNPP02MOD_A2012365_2304_n06095_K005.nc

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest level1c4pps
  • Passes flake8
  • Fully documented

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 36.84211% with 48 lines in your changes missing coverage. Please review.

Project coverage is 75.75%. Comparing base (39dae4d) to head (9b89b7a).
Report is 25 commits behind head on main.

Files Patch % Lines
level1c4pps/vgac2pps_lib.py 36.84% 45 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   77.27%   75.75%   -1.53%     
==========================================
  Files          21       23       +2     
  Lines        1474     1633     +159     
  Branches      126      141      +15     
==========================================
+ Hits         1139     1237      +98     
- Misses        308      360      +52     
- Partials       27       36       +9     
Flag Coverage Δ
unittests 75.75% <36.84%> (-1.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9777294376

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 31 of 75 (41.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on split_files at 77.329%

Changes Missing Coverage Covered Lines Changed/Added Lines %
level1c4pps/vgac2pps_lib.py 31 75 41.33%
Totals Coverage Status
Change from base Build 9107995984: 77.3%
Covered Lines: 1533
Relevant Lines: 1926

💛 - Coveralls

Nina.Hakansson added 2 commits July 3, 2024 14:28
We know that 1.7.3 is broken for numpy 2.0 but we do not know fo rnext version.

Other readers are working for numpy = 2.0.0.
Keep the CI tests for numpy 1.26.4
@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9777875117

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 37 of 84 (44.05%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on split_files at 77.161%

Changes Missing Coverage Covered Lines Changed/Added Lines %
level1c4pps/gac2pps_lib.py 2 5 40.0%
level1c4pps/vgac2pps_lib.py 31 75 41.33%
Totals Coverage Status
Change from base Build 9107995984: 77.2%
Covered Lines: 1535
Relevant Lines: 1931

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 5, 2024

Pull Request Test Coverage Report for Build 9805623438

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 86 of 97 (88.66%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on split_files at 79.571%

Changes Missing Coverage Covered Lines Changed/Added Lines %
level1c4pps/tests/test_vgac2pps.py 12 13 92.31%
level1c4pps/gac2pps_lib.py 2 5 40.0%
level1c4pps/vgac2pps_lib.py 68 75 90.67%
Totals Coverage Status
Change from base Build 9107995984: 79.6%
Covered Lines: 1584
Relevant Lines: 1944

💛 - Coveralls

@ninahakansson ninahakansson merged commit df8234f into foua-pps:main Jul 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants