Remove Old Foundation Files #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Foundation 6.4.1 refactored the `foundation.util.timerAndImageLoader` into separate files. * The imageLoader and timer utilities are already being loaded in `foundation.js`, so the older `timerAndImageLoader` can safely be removed from this repo. * Remove the out-of-date `foundation.zf.responsiveAccordionTabs.js` utility under the same rationale as above. * A separate PR will be made upstream against `foundation-sites` to remove these out of date files from the `dist` directory`. * Bump version to indicate that this is a bugfix. SEE: foundation/foundation-sites@0730b7b#diff-11ba5437268f42332a0ff3914daf8edd SEE: foundation/foundation-sites#9697
|
👍 +1 |
Versions should be bump only in package releases
ncoden
approved these changes
Mar 11, 2018
There was a problem hiding this comment.
Thanks @jessedoyle. LGTM 👍
I removed the version bump as this is something only the package maintainer should do when a new version is released.
|
Awesome thanks @ncoden! Sorry about the version bump! |
|
No problem @jessedoyle. Thanks for your contributions. |
ncoden
added a commit
to ncoden/foundation-rails
that referenced
this pull request
Mar 13, 2018
### Major changes: * Upgrade to Foundation `v6.4.3` (foundation#254, @chrisfinne) * Add Autoprefixer (foundation#255, @bassjobsen) ### Bug fixes: * Fix issue with smoothScroll import order (foundation#236 @MicahBrown) * Add missing SCSS components to template (foundation#237 @patricklindsay) * Prevent Sass depreciation (foundation#252, @michsch) ### Cleaning: * Remove old Foundation files (foundation#251 @jessedoyle) ### See also: * Foundation 6.4.3 release notes: https://github.com/zurb/foundation-sites/releases/tag/v6.4.3 * Foundation 6.4.2 release notes: https://github.com/zurb/foundation-sites/releases/tag/v6.4.2
jessedoyle
added a commit
to amaabca/ama_layout
that referenced
this pull request
Apr 11, 2018
* Remove the `util.timerAndImageLoader` reference in our custom foundation javascript includes because it is no longer present upstream. * Bump `foundation-rails` version to require `6.4.3.0` or higher. * This will bump our Foundation version from `6.4.1` to `6.4.3`. The changes that requires migration between these are to the xy-grid, which we do not currently use. SEE: https://github.com/zurb/foundation-sites/releases/tag/v6.4.2 SEE: foundation/foundation-rails#251
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
I think this gem may be including some utility JS code from older versions of Foundation.
In this diff, you can see that the
foundation.util.timerAndImageLoaderwas split into 2 separate JS files (timer.jsandimageLoader.js).The most current version of this gem appears to be loading both files here.
It also appears that the same scenario above played out with
foundation.responsiveAccordionTabs.js(newer) andfoundation.zf.responsiveAccordionTabs.js.I believe this was noted in this issue upstream: foundation/foundation-sites#9697.
I took the liberty of updating the version in this PR as a bugfix - please let me know if you wish to do this yourself.
Thanks!