Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run test across multiple rails versions #265

Merged
merged 4 commits into from
May 11, 2018
Merged

chore: run test across multiple rails versions #265

merged 4 commits into from
May 11, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented May 10, 2018 •
edited
Loading

Changes

  • Run tests on Rails 4.1, 4.2, 5.0, 5.1 and `5.2
  • Unpin dev dependencies when compatible with the tested version range

Others changes on tests:

  • Display generator logs in tests
  • Fix generator Foundation insertion in Js assets

Closes #256

@ncoden ncoden added the bug fix label May 10, 2018
@ncoden ncoden requested a review from mehlah May 10, 2018 22:42
@ncoden ncoden changed the title Chore/multiple rails versions tests chore: run test across multiple rails versions May 10, 2018
@ncoden ncoden mentioned this pull request May 10, 2018
Closed
@ncoden ncoden merged commit 71736a6 into foundation:develop May 11, 2018
@ncoden ncoden mentioned this pull request Nov 17, 2018
Merged
ncoden added a commit to brianmcoates/foundation-rails that referenced this pull request Jan 23, 2019
@ncoden
chore: accept newest Sass versions
ac74fb1 
Foundation-sites is compatible with the latest Sass versions.
Related to foundation#265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehlah mehlah Awaiting requested review from mehlah

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncoden @khiet @robinboening