-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
…errors in docs CSS
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
source "https://rubygems.org" | ||
|
||
gem "compass", "0.12.2" | ||
gem "sass", "~> 3.4.0" | ||
gem "compass", "~> 1.0.0" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,29 @@ | ||
GEM | ||
remote: https://rubygems.org/ | ||
specs: | ||
chunky_png (1.3.0) | ||
compass (0.12.2) | ||
chunky_png (1.3.1) | ||
compass (1.0.1) | ||
chunky_png (~> 1.2) | ||
fssm (>= 0.2.7) | ||
sass (~> 3.1) | ||
fssm (0.2.10) | ||
sass (3.2.14) | ||
compass-core (~> 1.0.1) | ||
compass-import-once (~> 1.0.5) | ||
rb-fsevent (>= 0.9.3) | ||
rb-inotify (>= 0.9) | ||
sass (>= 3.3.13, < 3.5) | ||
compass-core (1.0.1) | ||
multi_json (~> 1.0) | ||
sass (>= 3.3.0, < 3.5) | ||
compass-import-once (1.0.5) | ||
sass (>= 3.2, < 3.5) | ||
ffi (1.9.3) | ||
multi_json (1.10.1) | ||
rb-fsevent (0.9.4) | ||
rb-inotify (0.9.5) | ||
ffi (>= 0.5.0) | ||
sass (3.4.3) | ||
|
||
PLATFORMS | ||
ruby | ||
|
||
DEPENDENCIES | ||
compass (= 0.12.2) | ||
compass (~> 1.0.0) | ||
sass (~> 3.4.0) |
15 comments
on commit 8421ac4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I had to remove the !global to make it work with the last version of sass.
The error message was: bower_components/foundation/scss/foundation/functions:13: error: error reading values after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it Ruby Sass or libsass? This will work with Ruby Sass 3.3 and up but not libsass, unless you remove !global
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for needing to remove !global
to get libsass compiling again, it'd be great if this could be supported too, as opposed to having to break dependency.
Perhaps a compiler variable within _settings.scss
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue here.
The sass-rails (4.0.3)
gem (the latest stable version) has a sass (~> 3.2.0)
dependency, which resolves to sass (3.2.19)
. So this commit's causing Foundation 5.4.4 to fail (unless !global
is removed).
@oller's suggestion is probably best to enable backwards compatibility with older sass gems, even once sass-rails has caught up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same error here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could detect the libsass compiler using a user-defined variable (i.e. $libsass
) or Sass's feature-exists()
function, but even if you hide the !global
keyword inside an @if
statement, libsass will still notice it and throw an error.
Try opening this Sassmeister gist and switching between libsass and Ruby Sass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Scuppered! We'll have to update our scss/sass's somehow. Thanks for looking into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue at #5811
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're talking about removing the !global
flag to get back compatibility with Rails and libsass. We had a lot of Ruby users upgrading their Sass immediately and asking us about a fix when things stopped working, but we may have jumped the gun by upgrading to 3.4 right away.
If we roll back, the plan would be to remove the !global
flag and add a Gemfile to our Compass template (which is what the CLI installs when you run foundation new
) that enforces Sass 3.3. With no !global
flag, it will compile in 3.2 fine, which means it will compile in libsass and foundation-rails
just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be prudent @gakimball, give other compilers a little more time to catch up. In my case i'm using libsass, so this would work great, and mean I can keep patching as opposed to locking at 5.4.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gakimball Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for giving this priority. I'm not sure I'm clear on your proposal, but the fix should not require the CLI foundation new
command because many of us install manually or use the rails_layout gem in conjunction with Rails Composer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to address what what happened here. When Sass 3.4 came out, we saw tons of people trying to update (and create new) Compass projects with the latest Sass version. We had been holding off updating to Sass 3.3 for some time because we knew it would cause some breaking changes. So when people were letting us know about the widespread problems people were having with Compass. Due to the huge volume of those issues, complains on twitter, and forum posts, we made the decision to upgrade compatibility.
Even though we put put a warning the same day on the Libsass install instructions, it could have been handled better. Libsass is great and we used it on our internal projects. Compass had much greater adoption so we decided to make the fix for that user base. It's a tough problem because the Sass community is split and we need Foundation to support multiple versions of Sass.
Right now we are working to figure out this problem from another angle. @gakimball reworked part of the codebase and the import process to see if we can remove the need for !global which is what causes older Sass versions to choke. This should make it Sass 3.2, 3.3, and 3.4 compatible.
We are testing today and should be able to deploy later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation and the update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafibomb Thanks for the update, much appreciated.
@gakimball This is actually causing an error in our Rails app when we include
5.4.4
Screenshot at http://cl.ly/Xb19
Any ideas?