Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass manifest file to have semi-colons instead of commas #5494

Closed
vinayraghu opened this issue Jul 24, 2014 · 2 comments
Closed

Sass manifest file to have semi-colons instead of commas #5494

vinayraghu opened this issue Jul 24, 2014 · 2 comments
Labels
Milestone

Comments

@vinayraghu
Copy link
Contributor

The current sass manifest file foundation.scss is structured as follows

@import
"foundation/components/grid",
"foundation/components/accordion",
  ...,
"foundation/components/offcanvas",
"foundation/components/visibility";

Let's say I want to disable the last foundation sass import - visibility.scss like below. Since all imports end with commas instead of semi-colons, commenting out visibility will cause an error.

@import
"foundation/components/grid",
"foundation/components/accordion",
  ...,
"foundation/components/offcanvas",
// "foundation/components/visibility";

I will have to manually go to the previous component, change the trailing comma into a semi-colon like so:

@import
"foundation/components/grid",
"foundation/components/accordion",
  ...,
"foundation/components/offcanvas";
// "foundation/components/visibility";

Let's say in the future, I decide to include the visibility component. I have to remove the semi-colon I inserted, change it into a comma and then un-comment visibility

@import
"foundation/components/grid",
"foundation/components/accordion",
  ...,
"foundation/components/offcanvas",
"foundation/components/visibility";

It would be a lot easier if each file was a separate @import statement, so commenting out components is really just adding the comment at the correct line. No need to go about changing semi-colons or commas

@import "foundation/components/grid";
// @import  "foundation/components/accordion";
@import "etc";
@import  "foundation/components/offcanvas";
// @import "foundation/components/visibility";

Happy to send a PR if you guys think this makes sense

@rafibomb rafibomb added the scss label Jul 24, 2014
@rafibomb rafibomb added this to the 5.4 milestone Jul 24, 2014
@rafibomb rafibomb assigned zurbrandon and cmwinters and unassigned zurbrandon Jul 24, 2014
@cmwinters
Copy link
Contributor

Makes sense! 👍 If you submit a PR we'll merge, otherwise I'll work on a fix for this as I have time.

@vinayraghu
Copy link
Contributor Author

I'll close this over the weekend

cmwinters added a commit that referenced this issue Jul 28, 2014
Fix #5494 Make it easier to comment components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants