.menu-icon.dark repeated twice #9230
Labels
Comments
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this issue
Oct 6, 2016
foundation#9230 Remove `.menu-icon.dark` in `scss/components/_title-bar.scss`
|
Thank you. I didn't found any reasons for this code duplication. It should be a mistake. PR: #9241 |
samuelmc
added a commit
to samuelmc/foundation-sites
that referenced
this issue
Oct 7, 2016
* Make off canvas work no matter where you are on the page and avoids having to jump to the top. * Error in documentation Native element sass usage: @import replaced by @include, which it should be * Update progress-bar.md replace import by include * Add missing overflow style Add in missing `overflow-y: auto` to `.off-canvas-content` to allow for vertical scrolling. * Fix disabled button hover and focus state background color * Fix dropdown alternative anchor selection * Add settings for the hover color for thead and tfoot * Added !global back to $grid-column-count * Round rgb color values otherwise it will always be black * Fix iOS bug where opening a modal would cause the page to jump to top. * custom button hover lightness * custom button hover lightness settings * configurable pagination current page number on mobile * add default settings value for $pagination-mobile-current-item * foundation#9015 option to close drop menu on leaf anchor tag click * check if cb is a function * check if cb is a function * orbit: add event beforeslidechange I use this event to smoothly resize the orbit container for carousels with images of different heights * added event docblock for docs autogen * Enhanced functionality of Accordion. Click listener now only calls toggle(), which will then work the tab content up/down out on its own. * Added unit tests for Accordion. * Included feedback from PR. * Removed unused variable and check if target is active before executing up(). * Included done callback in describe call properly. * Added unit tests for Accordion Menu. * Adjusted test case for up(). * Fixed wrong reference to triggerClass option. * Added unit tests for Tooltip. * Remove version specification on composer.json as per issue foundation#9144 * Add "alert" as required map value to $foundation-palette Undefined "alert" color in $foundation-palette breaks SCSS compilation. Documentation incorrectly identifies "primary" as the only required value in the user redefined map. * Fixed toggling of ARIA attributes. * Added unit tests for Drilldown. * Fix last child to float to the global left direction. * Fix for flex grid not working correctly when applied to an element (namespaced). Part fix for foundation#9225 * Fixes the default grid to work when added to a container (namespaced). Fully fixes foundation#9225 * Fix incorrect flex grid output. The output should of been `.row .column.row.row, .row .row.row.columns` * Remove not needed `&` added during testing to find the problem. * Fixed missing newline at end of file. * Fix foundation#9230 - remove code duplication foundation#9230 Remove `.menu-icon.dark` in `scss/components/_title-bar.scss` * Get rid of JS scroll behavior on reveal taking advantage of change in scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As far as I can see, the
.menu-icon.darkclass is repeated twice; it is inserted by:components/_menu-icon.scss
components/_title-bar.scss
How to reproduce: simply download the complete css file and search for
.menu-icon.darkThe text was updated successfully, but these errors were encountered: