Fixed Magellan issue when target does not exist. #9070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent any scrolling action when the target of the clicked link does not exist. Previously the `.getOffset().top` created an JS error because `Cannot read property 'top' of undefined`. Also added a basic test for scrolling and a test for the graceful failing when the target does not exist.
|
Any feedback from @zurb/yetinauts ? |
|
This looks good, would we want a console log stating there is "no target, please check existence or spelling". Just a thought. Otherwise, merge it! |
|
@coreysyms Not sure if there is any Foundation-wide guideline on console logs. Maybe @kball can help? |
|
This looks good; I've fought with exactly this bug before. On console.logs... historically we don't include them in the codebase. I think @coreysyms has a good idea... I wonder if we should have a set of debug only logs that get compiled out in the production builds... for now, lets not worry about it. Going to merge both this and #9066. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent any scrolling action when the target of the clicked link does not exist.
Previously the
.getOffset().topcreated an JS error becauseCannot read property 'top' of undefined.Also added a basic test for scrolling and a test for the graceful failing when the target does not exist.
Noticed this issue when checking #9066.